f/aws_networkmanager_connect_attachment

[juhala-aws]

Description

This pull request adds a new resource Connect attachment to AWS Network Manager, updates Network Manager attachment accepter to accept this new attachment type and fixes one related issue in VPC attachment.

This PR fixes an issue in VPC attachment in delete function. Fis is related to this PR as Connect Attachment is using VPC attachment and VPC attachment tests are failing. Fail in tests happen if attachment accepter is used and attachment is deleted immediately after create. With attachment accepter, attachment state is left in Pending Acceptance state and delete fails as that is not an accepted state.

Relations

Relates #26420
Relates #25835

References

https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_CreateConnectAttachment.html
https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_DeleteAttachment.html

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerConnectAttachment'  -timeout 180m
=== RUN   TestAccNetworkManagerConnectAttachment_basic
=== PAUSE TestAccNetworkManagerConnectAttachment_basic
=== RUN   TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== PAUSE TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== RUN   TestAccNetworkManagerConnectAttachment_disappears
=== PAUSE TestAccNetworkManagerConnectAttachment_disappears
=== RUN   TestAccNetworkManagerConnectAttachment_tags
=== PAUSE TestAccNetworkManagerConnectAttachment_tags
=== CONT  TestAccNetworkManagerConnectAttachment_basic
=== CONT  TestAccNetworkManagerConnectAttachment_disappears
=== CONT  TestAccNetworkManagerConnectAttachment_tags
=== CONT  TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1146.60s)
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1188.98s)
--- PASS: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (1228.97s)
--- PASS: TestAccNetworkManagerConnectAttachment_disappears (1313.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1313.380s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerSiteToSiteVPNAttachment'  -timeout 180m
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1536.17s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1548.31s)
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1567.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1567.808s


==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerVPCAttachment'  -timeout 180m
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_update
=== PAUSE TestAccNetworkManagerVPCAttachment_update
=== CONT  TestAccNetworkManagerVPCAttachment_basic
=== CONT  TestAccNetworkManagerVPCAttachment_tags
=== CONT  TestAccNetworkManagerVPCAttachment_update
=== CONT  TestAccNetworkManagerVPCAttachment_disappears
--- PASS: TestAccNetworkManagerVPCAttachment_basic (790.14s)
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (856.55s)
--- PASS: TestAccNetworkManagerVPCAttachment_tags (938.29s)
--- PASS: TestAccNetworkManagerVPCAttachment_update (1112.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1112.244s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerSiteToSiteVPNAttachment_\|TestAccNetworkManagerVPCAttachment_\|TestAccNetworkManagerConnectAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerSiteToSiteVPNAttachment_\|TestAccNetworkManagerVPCAttachment_\|TestAccNetworkManagerConnectAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerConnectAttachment_basic
=== PAUSE TestAccNetworkManagerConnectAttachment_basic
=== RUN   TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== PAUSE TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
=== RUN   TestAccNetworkManagerConnectAttachment_disappears
=== PAUSE TestAccNetworkManagerConnectAttachment_disappears
=== RUN   TestAccNetworkManagerConnectAttachment_tags
=== PAUSE TestAccNetworkManagerConnectAttachment_tags
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_update
=== PAUSE TestAccNetworkManagerVPCAttachment_update
=== CONT  TestAccNetworkManagerConnectAttachment_basic
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_tags
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1224.49s)
=== CONT  TestAccNetworkManagerConnectAttachment_tags
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1355.57s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_disappears
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1270.34s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_basic
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_disappears (1444.16s)
=== CONT  TestAccNetworkManagerConnectAttachment_disappears
--- PASS: TestAccNetworkManagerConnectAttachment_disappears (1238.36s)
=== CONT  TestAccNetworkManagerVPCAttachment_tags
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1556.93s)
=== CONT  TestAccNetworkManagerVPCAttachment_update
--- PASS: TestAccNetworkManagerVPCAttachment_update (1219.61s)
=== CONT  TestAccNetworkManagerVPCAttachment_disappears
--- PASS: TestAccNetworkManagerVPCAttachment_tags (1123.31s)
=== CONT  TestAccNetworkManagerVPCAttachment_basic
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (832.92s)
=== CONT  TestAccNetworkManagerConnectAttachment_basic_NoDependsOn
--- PASS: TestAccNetworkManagerVPCAttachment_basic (708.41s)
--- PASS: TestAccNetworkManagerConnectAttachment_basic_NoDependsOn (1273.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	6439.081s

[ewbankkit]

@juhala-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.