aws_networkmanager_attachment_accepter NOT accepting the other type of attachments.

[Hemant40]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

[root@localhost Terraform]# terraform -v
Terraform v1.2.7
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v4.27.0
+ provider registry.terraform.io/hashicorp/awscc v0.30.0

Affected Resource(s)

• aws_networkmanager_attachment_accepter

Expected Behavior

The provided module aws_networkmanager_attachment_accepter in (#26227) should accept all kind of attachments but currently it is only accepting the VPC attachment.

i have a site_to_site_vpn attachment which needs to be attached along with the VPC attachment but the new module is giving an error that only VPC attachment can be accepted with this module.

╷
│ Error: expected attachment_type to be one of [VPC], got SITE_TO_SITE_VPN
│
│ with aws_networkmanager_attachment_accepter.vpn_acc,
│ on cloud_wan.tf line 63, in resource "aws_networkmanager_attachment_accepter" "vpn_acc":
│ 63: attachment_type = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.attachment_type

Actual Behavior

The new module aws_networkmanager_attachment_accepter should accept all the attachments regardless of the attachment type.

Steps to Reproduce

resource "awscc_networkmanager_site_to_site_vpn_attachment" "vpn_attachment" {
  core_network_id         = awscc_networkmanager_core_network.core_network.id
  vpn_connection_arn      = aws_vpn_connection.example.arn

  tags                    = [
    { key = "Name", value = "vpn"},
    { key = "segment", value = "shared"}
  ]
}

#resource "aws_networkmanager_attachment_accepter" "vpn_acc" {
#  attachment_id   = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.id
#  attachment_type = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.attachment_type
#}

I am adding a snapshot where we can see that the VPC attachment is accepted but site_to_site_vpn attachment is not accepted.

Please let me know if anything else is needed from my side.

Relates #25835.

[Hemant40]

@ewbankkit, Would you be kind enough to provide if there is an ETA for this task.

[github-actions]

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.