Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource] aws_identitystore_group_membership #26944

Merged
merged 14 commits into from
Sep 28, 2022
Merged

[New Resource] aws_identitystore_group_membership #26944

merged 14 commits into from
Sep 28, 2022

Conversation

bengisc
Copy link

@bengisc bengisc commented Sep 22, 2022 •
edited by ewbankkit
Loading

Closes #26939.
Relates #26948.
Relates #26674.

Output from acceptance testing:

make testacc TESTS=TestAccIdentityStoreGroupMembership_ PKG=identitystore
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroupMembership_'  -timeout 180m
=== RUN   TestAccIdentityStoreGroupMembership_basic
=== PAUSE TestAccIdentityStoreGroupMembership_basic
=== RUN   TestAccIdentityStoreGroupMembership_disappears
=== PAUSE TestAccIdentityStoreGroupMembership_disappears
=== RUN   TestAccIdentityStoreGroupMembership_GroupId
=== PAUSE TestAccIdentityStoreGroupMembership_GroupId
=== RUN   TestAccIdentityStoreGroupMembership_MemberId
=== PAUSE TestAccIdentityStoreGroupMembership_MemberId
=== CONT  TestAccIdentityStoreGroupMembership_basic
=== CONT  TestAccIdentityStoreGroupMembership_MemberId
=== CONT  TestAccIdentityStoreGroupMembership_disappears
=== CONT  TestAccIdentityStoreGroupMembership_GroupId
--- PASS: TestAccIdentityStoreGroupMembership_disappears (28.90s)
--- PASS: TestAccIdentityStoreGroupMembership_basic (33.65s)
--- PASS: TestAccIdentityStoreGroupMembership_MemberId (51.80s)
--- PASS: TestAccIdentityStoreGroupMembership_GroupId (51.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	56.587s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/identitystore Issues and PRs that pertain to the identitystore service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 22, 2022
github-actions[bot]
github-actions bot reviewed Sep 22, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bengisc 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

bschaatsbergen
bschaatsbergen reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few drive by comments; nice work so far.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. examples Introduces or discusses updates to examples. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appsync Issues and PRs that pertain to the appsync service. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Sep 28, 2022
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/events Issues and PRs that pertain to the events service. github_actions Pull requests that update Github_actions code skaff Issues and pull requested related to the skaff tool service/ds Issues and PRs that pertain to the ds service. service/logs Issues and PRs that pertain to the logs service. service/inspector2 Issues and PRs that pertain to the inspector2 service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Sep 28, 2022
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. labels Sep 28, 2022
ewbankkit
ewbankkit approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreGroupMembership_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroupMembership_ -timeout 180m
=== RUN   TestAccIdentityStoreGroupMembership_basic
=== PAUSE TestAccIdentityStoreGroupMembership_basic
=== RUN   TestAccIdentityStoreGroupMembership_disappears
=== PAUSE TestAccIdentityStoreGroupMembership_disappears
=== RUN   TestAccIdentityStoreGroupMembership_GroupId
=== PAUSE TestAccIdentityStoreGroupMembership_GroupId
=== RUN   TestAccIdentityStoreGroupMembership_MemberId
=== PAUSE TestAccIdentityStoreGroupMembership_MemberId
=== CONT  TestAccIdentityStoreGroupMembership_basic
=== CONT  TestAccIdentityStoreGroupMembership_GroupId
--- PASS: TestAccIdentityStoreGroupMembership_basic (22.57s)
=== CONT  TestAccIdentityStoreGroupMembership_MemberId
--- PASS: TestAccIdentityStoreGroupMembership_GroupId (38.89s)
=== CONT  TestAccIdentityStoreGroupMembership_disappears
--- PASS: TestAccIdentityStoreGroupMembership_disappears (17.15s)
--- PASS: TestAccIdentityStoreGroupMembership_MemberId (36.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	62.995s

@ewbankkit
Copy link
Contributor

@bengisc Thanks for the contribution 🎉 👏.

There must have been some glitch with the PR labeler GitHub Action that caused all those labels to be added.
I manually tidied them up.

@ewbankkit ewbankkit merged commit b95b99a into hashicorp:main Sep 28, 2022
@github-actions github-actions bot added this to the v4.33.0 milestone Sep 28, 2022
@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@bengisc bengisc mentioned this pull request Oct 14, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@bschaatsbergen bschaatsbergen bschaatsbergen left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/identitystore Issues and PRs that pertain to the identitystore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.33.0
Development

Successfully merging this pull request may close these issues.

[New Resource] aws_identitystore_group_membership
3 participants
@bengisc @ewbankkit @bschaatsbergen