Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing functionality for AppFlow Custom Connector #26766

Merged
merged 9 commits into from
Dec 21, 2022

Conversation

daniepett
Copy link

@daniepett daniepett commented Sep 12, 2022

Adding functionality of AppFlow Custom Connector to match the docs. In the current state the Custom Connector resource always returns empty values and fails on create.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #26665
Closes #26780

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/appflow Issues and PRs that pertain to the appflow service. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Sep 12, 2022
@justinretzolk
Copy link
Member

justinretzolk commented Sep 12, 2022

Fixes #26665

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 12, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Sep 13, 2022
@daniepett daniepett changed the title fix: Add missing functionality for AppFlow Custom Connector feat: Add missing functionality for AppFlow Custom Connector Sep 28, 2022
@dude0001
Copy link

dude0001 commented Oct 7, 2022

What is needed to move this PR forward? @justinretzolk

@ghost
Copy link

ghost commented Dec 2, 2022

What more is required for this to be merged?

@dude0001
Copy link

What more is required for this to be merged?

I was told it isn't priority. We are having luck using the AWS Cloud Control provider.

@ghost
Copy link

ghost commented Dec 12, 2022

Thanks, @dude0001 for the update. Here's a current link for anyone who comes along: https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/appflow_connector_profile

@johnsonaj johnsonaj self-assigned this Dec 20, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 21, 2022
@johnsonaj johnsonaj self-requested a review December 21, 2022 17:13
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccAppFlowConnectorProfile_' PKG=appflow

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20  -run=TestAccAppFlowConnectorProfile_ -timeout 180m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (241.82s)
--- PASS: TestAccAppFlowConnectorProfile_update (251.30s)
--- PASS: TestAccAppFlowConnectorProfile_basic (298.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	301.382s

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 21, 2022
@johnsonaj
Copy link
Contributor

@daniepett thanks for the contribution 👏🏾 🎉

@johnsonaj johnsonaj merged commit 9005c15 into hashicorp:main Dec 21, 2022
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppFlow missing support for custom connectors
4 participants