Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppFlow missing support for custom connectors #26780

Closed
daniepett opened this issue Sep 13, 2022 · 4 comments · Fixed by #26766
Closed

AppFlow missing support for custom connectors #26780

daniepett opened this issue Sep 13, 2022 · 4 comments · Fixed by #26766
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service.
Milestone

Comments

@daniepett
Copy link

daniepett commented Sep 13, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v1.1.7
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.30.0

Affected Resource(s)

  • aws_appflow_connector_profile

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_appflow_connector_profile" "test" {
  name            = "salesforce_marketing_cloud"
  connector_type  = "CustomConnector"
  connection_mode = "Public"
  connector_label = "SalesforceMarketingCloud"
  connector_profile_config {
    connector_profile_credentials {
      custom_connector {
        authentication_type = "OAUTH2"
        oauth2 {
          client_id     = "testID"
          client_secret = "testSecret"
          oauth_request {
            redirect_uri = "https://test1234.rest.marketingcloudapis.com/"
          }
        }
      }
    }
    connector_profile_properties {
      custom_connector {
        oauth2_properties {
          oauth2_grant_type = "CLIENT_CREDENTIALS"
          token_url         = "https://test1234.auth.marketingcloudapis.com/v2/token"
        }
        profile_properties = {
          "instanceUrl" = "https://test1234.rest.marketingcloudapis.com/"
        }
      }
    }
  }
}

Expected Behavior

Resource created according to documentation

Actual Behavior

Error: creating AppFlow Connector Profile: ValidationException: connectorProfileConfig: properties/credentials is null for ConnectorType: CUSTOMCONNECTOR

Debug JSON

{
    "connectionMode": "Public",
    "connectorLabel": "SalesforceMarketingCloud",
    "connectorProfileConfig": {
        "connectorProfileCredentials": {
            "CustomConnector": {
                "authenticationType": "OAUTH2"
            }
        },
        "connectorProfileProperties": {}
    },
    "connectorProfileName": "salesforce_marketing_cloud",
    "connectorType": "CustomConnector"
}

Steps to Reproduce

  1. terraform apply

Important Factoids

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appflow_connector_profile#custom-connector-profile-credentials

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/appflow Issues and PRs that pertain to the appflow service. labels Sep 13, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2022
@dude0001
Copy link

It looks like a rather small change #26766 is needed for this and ready to go. @daniepett @justinretzolk what else is needed to get this on a release?

@justinretzolk
Copy link
Member

Hey @dude0001 👋 Thank you for checking in on this. Unfortunately, I'm not able to provide an estimate on when this will be looked into due to the potential of shifting priorities (we prioritize work by count of ":+1:" reactions, as well as a few other things). For more information on how we prioritize, check out out prioritization guide.

@github-actions github-actions bot added this to the v4.49.0 milestone Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants