Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_identitystore_group #26674

Merged
merged 26 commits into from
Sep 27, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Sep 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26606

Output from acceptance testing:

$ make testacc TESTS=TestAccIdentityStoreGroup_basic PKG=identitystore                                   (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroup_basic'  -timeout 180m
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroup_basic
--- PASS: TestAccIdentityStoreGroup_basic (31.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      31.120s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/identitystore Issues and PRs that pertain to the identitystore service. labels Sep 6, 2022
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Sep 6, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2022
@kyle-c-simmons
Copy link

Any updates on this?

@bschaatsbergen
Copy link
Member Author

Any updates on this?

It's WIP at the moment. I'm trying to get it done in the coming few days.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Sep 14, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review September 14, 2022 22:03
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 14, 2022
@dougforster-at
Copy link

Thanks for working on this, looking forward to it!

internal/service/identitystore/group.go Outdated Show resolved Hide resolved
internal/service/identitystore/group.go Outdated Show resolved Hide resolved
internal/service/identitystore/group.go Outdated Show resolved Hide resolved
website/docs/r/identitystore_group.html.markdown Outdated Show resolved Hide resolved
website/docs/r/identitystore_group.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIdentityStoreGroup_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2  -run=TestAccIdentityStoreGroup_ -timeout 180m
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreGroup_disappears
=== PAUSE TestAccIdentityStoreGroup_disappears
=== CONT  TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroup_disappears
--- PASS: TestAccIdentityStoreGroup_disappears (19.53s)
--- PASS: TestAccIdentityStoreGroup_basic (23.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	27.951s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/identitystore Issues and PRs that pertain to the identitystore service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Resource: aws_identitystore_group
6 participants