Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_apprunner_observability_configuration #25591

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Jun 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25575

Output from acceptance testing:

bruno@pop-os ~/G/terraform-provider-aws (r/25575-app-runner-observability-configuration)> make testacc TESTS=TestAccAppRunnerObservabilityConfiguration_ PKG=apprunner                                                (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerObservabilityConfiguration_'  -timeout 180m
=== RUN   TestAccAppRunnerObservabilityConfiguration_basic
=== PAUSE TestAccAppRunnerObservabilityConfiguration_basic
=== RUN   TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== PAUSE TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== RUN   TestAccAppRunnerObservabilityConfiguration_disappears
=== PAUSE TestAccAppRunnerObservabilityConfiguration_disappears
=== RUN   TestAccAppRunnerObservabilityConfiguration_tags
=== PAUSE TestAccAppRunnerObservabilityConfiguration_tags
=== CONT  TestAccAppRunnerObservabilityConfiguration_basic
=== CONT  TestAccAppRunnerObservabilityConfiguration_disappears
=== CONT  TestAccAppRunnerObservabilityConfiguration_tags
=== CONT  TestAccAppRunnerObservabilityConfiguration_traceConfiguration
--- PASS: TestAccAppRunnerObservabilityConfiguration_disappears (19.69s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_traceConfiguration (26.96s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_basic (27.79s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_tags (64.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  64.264s

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Jun 27, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 27, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jun 28, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 28, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review June 28, 2022 22:10
@bschaatsbergen bschaatsbergen changed the title [WIP] - New resource aws_apprunner_observability_configuration New resource aws_apprunner_observability_configuration Jun 28, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 29, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerObservabilityConfiguration_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerObservabilityConfiguration_ -timeout 180m
=== RUN   TestAccAppRunnerObservabilityConfiguration_basic
=== PAUSE TestAccAppRunnerObservabilityConfiguration_basic
=== RUN   TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== PAUSE TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== RUN   TestAccAppRunnerObservabilityConfiguration_disappears
=== PAUSE TestAccAppRunnerObservabilityConfiguration_disappears
=== RUN   TestAccAppRunnerObservabilityConfiguration_tags
=== PAUSE TestAccAppRunnerObservabilityConfiguration_tags
=== CONT  TestAccAppRunnerObservabilityConfiguration_basic
=== CONT  TestAccAppRunnerObservabilityConfiguration_disappears
--- PASS: TestAccAppRunnerObservabilityConfiguration_disappears (14.39s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_traceConfiguration
--- PASS: TestAccAppRunnerObservabilityConfiguration_basic (19.31s)
=== CONT  TestAccAppRunnerObservabilityConfiguration_tags
--- PASS: TestAccAppRunnerObservabilityConfiguration_traceConfiguration (16.36s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_tags (40.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	64.833s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f272276 into hashicorp:main Jun 29, 2022
@github-actions github-actions bot added this to the v4.21.0 milestone Jun 29, 2022
@yimipeng
Copy link

Thanks @bschaatsbergen 's contribution!

Btw I do not see doc update in https://registry.terraform.io/providers/hashicorp/aws/latest/docs to include new resource. Can someone help catch it up? Thanks.

@bschaatsbergen
Copy link
Member Author

bschaatsbergen commented Jun 29, 2022

@yimipeng, the version displayed on the website is v4.20.1, this feature has been merged into our v4.21.0 release which is scheduled to go-live soon.

image

Resource documentation has been added as part of the PR, see https://github.com/hashicorp/terraform-provider-aws/blob/main/website/docs/r/apprunner_observability_configuration.html.markdown.

Once v4.21.0 is released anytime soon, the resource will be available through this Terraform provider and the documentation will be visible on the website.

@bschaatsbergen bschaatsbergen deleted the r/25575-app-runner-observability-configuration branch June 29, 2022 17:07
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS App Runner ObservabilityConfiguration resource support
3 participants