-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource aws_apprunner_observability_configuration
#25591
New resource aws_apprunner_observability_configuration
#25591
Conversation
…lityConfiguration_traceConfiguration`
aws_apprunner_observability_configuration
aws_apprunner_observability_configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppRunnerObservabilityConfiguration_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2 -run=TestAccAppRunnerObservabilityConfiguration_ -timeout 180m
=== RUN TestAccAppRunnerObservabilityConfiguration_basic
=== PAUSE TestAccAppRunnerObservabilityConfiguration_basic
=== RUN TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== PAUSE TestAccAppRunnerObservabilityConfiguration_traceConfiguration
=== RUN TestAccAppRunnerObservabilityConfiguration_disappears
=== PAUSE TestAccAppRunnerObservabilityConfiguration_disappears
=== RUN TestAccAppRunnerObservabilityConfiguration_tags
=== PAUSE TestAccAppRunnerObservabilityConfiguration_tags
=== CONT TestAccAppRunnerObservabilityConfiguration_basic
=== CONT TestAccAppRunnerObservabilityConfiguration_disappears
--- PASS: TestAccAppRunnerObservabilityConfiguration_disappears (14.39s)
=== CONT TestAccAppRunnerObservabilityConfiguration_traceConfiguration
--- PASS: TestAccAppRunnerObservabilityConfiguration_basic (19.31s)
=== CONT TestAccAppRunnerObservabilityConfiguration_tags
--- PASS: TestAccAppRunnerObservabilityConfiguration_traceConfiguration (16.36s)
--- PASS: TestAccAppRunnerObservabilityConfiguration_tags (40.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 64.833s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
Thanks @bschaatsbergen 's contribution! Btw I do not see doc update in https://registry.terraform.io/providers/hashicorp/aws/latest/docs to include new resource. Can someone help catch it up? Thanks. |
@yimipeng, the version displayed on the website is v4.20.1, this feature has been merged into our v4.21.0 release which is scheduled to go-live soon. Resource documentation has been added as part of the PR, see https://github.com/hashicorp/terraform-provider-aws/blob/main/website/docs/r/apprunner_observability_configuration.html.markdown. Once v4.21.0 is released anytime soon, the resource will be available through this Terraform provider and the documentation will be visible on the website. |
This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25575
Output from acceptance testing: