Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/cognito_user_pool_client - add enable_propagate_additional_user_context_data argument + use finders #25181

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 5, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccCognitoIDPUserPoolClient_ PKG=cognitoidp
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (29.14s)
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (34.31s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (39.19s)
--- PASS: TestAccCognitoIDPUserPoolClient_basic (39.27s)
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (41.39s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (56.55s)
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (57.89s)
--- PASS: TestAccCognitoIDPUserPoolClient_name (59.74s)
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (59.92s)
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (60.13s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (60.36s)
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (60.58s)
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (77.71s)
--- PASS: TestAccCognitoIDPUserPoolClient_analytics (89.30s)
$ make testacc TESTS=TestAccCognitoIDPUserPoolClientDataSource_basic PKG=cognitoidp
--- PASS: TestAccCognitoIDPUserPoolClientDataSource_basic (32.31s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 5, 2022 16:40
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClient_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2  -run=TestAccCognitoIDPUserPoolClient_ -timeout 180m
=== RUN   TestAccCognitoIDPUserPoolClient_basic
=== PAUSE TestAccCognitoIDPUserPoolClient_basic
=== RUN   TestAccCognitoIDPUserPoolClient_enableRevocation
=== PAUSE TestAccCognitoIDPUserPoolClient_enableRevocation
=== RUN   TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_idTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_idTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== RUN   TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== RUN   TestAccCognitoIDPUserPoolClient_name
=== PAUSE TestAccCognitoIDPUserPoolClient_name
=== RUN   TestAccCognitoIDPUserPoolClient_allFields
=== PAUSE TestAccCognitoIDPUserPoolClient_allFields
=== RUN   TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== RUN   TestAccCognitoIDPUserPoolClient_analytics
=== PAUSE TestAccCognitoIDPUserPoolClient_analytics
=== RUN   TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== PAUSE TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== RUN   TestAccCognitoIDPUserPoolClient_disappears
=== PAUSE TestAccCognitoIDPUserPoolClient_disappears
=== RUN   TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== PAUSE TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== CONT  TestAccCognitoIDPUserPoolClient_basic
=== CONT  TestAccCognitoIDPUserPoolClient_name
--- PASS: TestAccCognitoIDPUserPoolClient_basic (22.27s)
=== CONT  TestAccCognitoIDPUserPoolClient_analyticsWithARN
--- PASS: TestAccCognitoIDPUserPoolClient_name (37.95s)
=== CONT  TestAccCognitoIDPUserPoolClient_Disappears_userPool
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (24.61s)
=== CONT  TestAccCognitoIDPUserPoolClient_disappears
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (15.15s)
=== CONT  TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (16.40s)
=== CONT  TestAccCognitoIDPUserPoolClient_analytics
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (31.18s)
=== CONT  TestAccCognitoIDPUserPoolClient_allFields
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (19.10s)
=== CONT  TestAccCognitoIDPUserPoolClient_idTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_analytics (48.52s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (33.00s)
=== CONT  TestAccCognitoIDPUserPoolClient_tokenValidityUnits
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (36.12s)
=== CONT  TestAccCognitoIDPUserPoolClient_enableRevocation
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (33.64s)
=== CONT  TestAccCognitoIDPUserPoolClient_accessTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (42.97s)
=== CONT  TestAccCognitoIDPUserPoolClient_refreshTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (30.86s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (31.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	226.305s

@ewbankkit ewbankkit merged commit 25ee971 into hashicorp:main Jun 6, 2022
@github-actions github-actions bot added this to the v4.18.0 milestone Jun 6, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the cognito-idp-arg branch June 23, 2022 06:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants