Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/dlm_lifecycle_policy - add missing arguments #23880

Merged
merged 31 commits into from
Mar 28, 2022
Merged

r/dlm_lifecycle_policy - add missing arguments #23880

merged 31 commits into from
Mar 28, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 25, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Supersedes #13889
Supersedes #11503
Supersedes #14348
Closes #11456
Closes #16520
Closes #23677
Closes #20040
Closes #14832 (via cron addition)
Closes #10726
Closes #9108
Closes #10802
Closes #21100

Output from acceptance testing:

$ make testacc TESTS=TestAccDLMLifecyclePolicy_ PKG=dlm

--- PASS: TestAccDLMLifecyclePolicy_disappears (38.89s)
--- PASS: TestAccDLMLifecyclePolicy_parameters_instance (43.63s)
--- PASS: TestAccDLMLifecyclePolicy_variableTags (44.10s)
--- PASS: TestAccDLMLifecyclePolicy_basic (45.12s)
--- PASS: TestAccDLMLifecyclePolicy_deprecate (45.16s)
--- PASS: TestAccDLMLifecyclePolicy_parameters_volume (45.18s)
--- PASS: TestAccDLMLifecyclePolicy_shareRule (45.22s)
--- PASS: TestAccDLMLifecyclePolicy_fastRestore (45.41s)
--- PASS: TestAccDLMLifecyclePolicy_retainInterval (45.80s)
--- PASS: TestAccDLMLifecyclePolicy_cron (46.10s)
--- PASS: TestAccDLMLifecyclePolicy_full (69.80s)
--- PASS: TestAccDLMLifecyclePolicy_tags (93.32s)
--- PASS: TestAccDLMLifecyclePolicy_crossRegionCopyRule (112.51s)
--- PASS: TestAccDLMLifecyclePolicy_event (133.14s)

Thanks @niklaskhf, @thatderek, and @marcjay for their work on this

@github-actions github-actions bot added service/dlm Issues and PRs that pertain to the dlm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Mar 25, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 25, 2022
@DrFaust92 DrFaust92 changed the title r/dlm_lifecycle_policy - add arguments r/dlm_lifecycle_policy - add missing arguments Mar 25, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 25, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Mar 25, 2022
@DrFaust92
Copy link
Collaborator Author

Sorry for this being a bit big but I added all missing DLM features as its only a single resource for the whole service.

@DrFaust92 DrFaust92 marked this pull request as ready for review March 26, 2022 17:56
This was referenced Mar 28, 2022
Closed
Closed
Closed
@ewbankkit
Ensure that DLM sweeper(s) are run.
1c167f3
@ewbankkit
Merge branch 'dlm' of https://github.com/DrFaust92/terraform-provider…
af30b5f 
…-aws into HEAD
@ewbankkit
Fix 'Error: error creating DLM Lifecycle Policy: InvalidRequestExcept…
b80f7a7 
…ion: The following parameter(s) are invalid: Too many AvailabilityZones in Schedule {tf-acc-basic}. {12} is more than the limit of 10'.
ewbankkit
ewbankkit approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccDLMLifecyclePolicy_ PKG=dlm ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dlm/... -v -count 1 -parallel 2 -run='TestAccDLMLifecyclePolicy_'  -timeout 180m
=== RUN   TestAccDLMLifecyclePolicy_basic
=== PAUSE TestAccDLMLifecyclePolicy_basic
=== RUN   TestAccDLMLifecyclePolicy_event
=== PAUSE TestAccDLMLifecyclePolicy_event
=== RUN   TestAccDLMLifecyclePolicy_cron
=== PAUSE TestAccDLMLifecyclePolicy_cron
=== RUN   TestAccDLMLifecyclePolicy_retainInterval
=== PAUSE TestAccDLMLifecyclePolicy_retainInterval
=== RUN   TestAccDLMLifecyclePolicy_deprecate
=== PAUSE TestAccDLMLifecyclePolicy_deprecate
=== RUN   TestAccDLMLifecyclePolicy_fastRestore
=== PAUSE TestAccDLMLifecyclePolicy_fastRestore
=== RUN   TestAccDLMLifecyclePolicy_shareRule
=== PAUSE TestAccDLMLifecyclePolicy_shareRule
=== RUN   TestAccDLMLifecyclePolicy_parameters_instance
=== PAUSE TestAccDLMLifecyclePolicy_parameters_instance
=== RUN   TestAccDLMLifecyclePolicy_parameters_volume
=== PAUSE TestAccDLMLifecyclePolicy_parameters_volume
=== RUN   TestAccDLMLifecyclePolicy_variableTags
=== PAUSE TestAccDLMLifecyclePolicy_variableTags
=== RUN   TestAccDLMLifecyclePolicy_full
=== PAUSE TestAccDLMLifecyclePolicy_full
=== RUN   TestAccDLMLifecyclePolicy_crossRegionCopyRule
=== PAUSE TestAccDLMLifecyclePolicy_crossRegionCopyRule
=== RUN   TestAccDLMLifecyclePolicy_tags
=== PAUSE TestAccDLMLifecyclePolicy_tags
=== RUN   TestAccDLMLifecyclePolicy_disappears
=== PAUSE TestAccDLMLifecyclePolicy_disappears
=== CONT  TestAccDLMLifecyclePolicy_basic
=== CONT  TestAccDLMLifecyclePolicy_parameters_instance
--- PASS: TestAccDLMLifecyclePolicy_basic (22.73s)
=== CONT  TestAccDLMLifecyclePolicy_deprecate
--- PASS: TestAccDLMLifecyclePolicy_parameters_instance (23.04s)
=== CONT  TestAccDLMLifecyclePolicy_shareRule
--- PASS: TestAccDLMLifecyclePolicy_shareRule (22.22s)
=== CONT  TestAccDLMLifecyclePolicy_fastRestore
--- PASS: TestAccDLMLifecyclePolicy_deprecate (26.48s)
=== CONT  TestAccDLMLifecyclePolicy_crossRegionCopyRule
--- PASS: TestAccDLMLifecyclePolicy_fastRestore (30.21s)
=== CONT  TestAccDLMLifecyclePolicy_disappears
--- PASS: TestAccDLMLifecyclePolicy_disappears (16.08s)
=== CONT  TestAccDLMLifecyclePolicy_tags
--- PASS: TestAccDLMLifecyclePolicy_crossRegionCopyRule (63.23s)
=== CONT  TestAccDLMLifecyclePolicy_variableTags
--- PASS: TestAccDLMLifecyclePolicy_variableTags (28.30s)
=== CONT  TestAccDLMLifecyclePolicy_full
--- PASS: TestAccDLMLifecyclePolicy_tags (49.40s)
=== CONT  TestAccDLMLifecyclePolicy_parameters_volume
--- PASS: TestAccDLMLifecyclePolicy_parameters_volume (20.20s)
=== CONT  TestAccDLMLifecyclePolicy_cron
--- PASS: TestAccDLMLifecyclePolicy_cron (19.10s)
=== CONT  TestAccDLMLifecyclePolicy_retainInterval
--- PASS: TestAccDLMLifecyclePolicy_full (45.69s)
=== CONT  TestAccDLMLifecyclePolicy_event
--- PASS: TestAccDLMLifecyclePolicy_retainInterval (27.00s)
--- PASS: TestAccDLMLifecyclePolicy_event (80.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	270.300s
GovCloud
% make testacc TESTS=TestAccDLMLifecyclePolicy_ PKG=dlm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dlm/... -v -count 1 -parallel 2 -run='TestAccDLMLifecyclePolicy_'  -timeout 180m
=== RUN   TestAccDLMLifecyclePolicy_basic
=== PAUSE TestAccDLMLifecyclePolicy_basic
=== RUN   TestAccDLMLifecyclePolicy_event
=== PAUSE TestAccDLMLifecyclePolicy_event
=== RUN   TestAccDLMLifecyclePolicy_cron
=== PAUSE TestAccDLMLifecyclePolicy_cron
=== RUN   TestAccDLMLifecyclePolicy_retainInterval
=== PAUSE TestAccDLMLifecyclePolicy_retainInterval
=== RUN   TestAccDLMLifecyclePolicy_deprecate
=== PAUSE TestAccDLMLifecyclePolicy_deprecate
=== RUN   TestAccDLMLifecyclePolicy_fastRestore
=== PAUSE TestAccDLMLifecyclePolicy_fastRestore
=== RUN   TestAccDLMLifecyclePolicy_shareRule
=== PAUSE TestAccDLMLifecyclePolicy_shareRule
=== RUN   TestAccDLMLifecyclePolicy_parameters_instance
=== PAUSE TestAccDLMLifecyclePolicy_parameters_instance
=== RUN   TestAccDLMLifecyclePolicy_parameters_volume
=== PAUSE TestAccDLMLifecyclePolicy_parameters_volume
=== RUN   TestAccDLMLifecyclePolicy_variableTags
=== PAUSE TestAccDLMLifecyclePolicy_variableTags
=== RUN   TestAccDLMLifecyclePolicy_full
=== PAUSE TestAccDLMLifecyclePolicy_full
=== RUN   TestAccDLMLifecyclePolicy_crossRegionCopyRule
=== PAUSE TestAccDLMLifecyclePolicy_crossRegionCopyRule
=== RUN   TestAccDLMLifecyclePolicy_tags
=== PAUSE TestAccDLMLifecyclePolicy_tags
=== RUN   TestAccDLMLifecyclePolicy_disappears
=== PAUSE TestAccDLMLifecyclePolicy_disappears
=== CONT  TestAccDLMLifecyclePolicy_basic
=== CONT  TestAccDLMLifecyclePolicy_parameters_instance
--- PASS: TestAccDLMLifecyclePolicy_parameters_instance (25.17s)
=== CONT  TestAccDLMLifecyclePolicy_deprecate
--- PASS: TestAccDLMLifecyclePolicy_basic (25.31s)
=== CONT  TestAccDLMLifecyclePolicy_shareRule
--- PASS: TestAccDLMLifecyclePolicy_deprecate (19.41s)
=== CONT  TestAccDLMLifecyclePolicy_fastRestore
--- PASS: TestAccDLMLifecyclePolicy_shareRule (21.16s)
=== CONT  TestAccDLMLifecyclePolicy_cron
--- PASS: TestAccDLMLifecyclePolicy_fastRestore (23.22s)
=== CONT  TestAccDLMLifecyclePolicy_retainInterval
--- PASS: TestAccDLMLifecyclePolicy_cron (22.98s)
=== CONT  TestAccDLMLifecyclePolicy_crossRegionCopyRule
--- PASS: TestAccDLMLifecyclePolicy_retainInterval (19.52s)
=== CONT  TestAccDLMLifecyclePolicy_disappears
--- PASS: TestAccDLMLifecyclePolicy_disappears (15.98s)
=== CONT  TestAccDLMLifecyclePolicy_tags
--- PASS: TestAccDLMLifecyclePolicy_crossRegionCopyRule (58.19s)
=== CONT  TestAccDLMLifecyclePolicy_event
--- PASS: TestAccDLMLifecyclePolicy_tags (50.58s)
=== CONT  TestAccDLMLifecyclePolicy_parameters_volume
--- PASS: TestAccDLMLifecyclePolicy_event (41.05s)
=== CONT  TestAccDLMLifecyclePolicy_full
--- PASS: TestAccDLMLifecyclePolicy_parameters_volume (19.94s)
=== CONT  TestAccDLMLifecyclePolicy_variableTags
--- PASS: TestAccDLMLifecyclePolicy_variableTags (19.45s)
--- PASS: TestAccDLMLifecyclePolicy_full (32.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	204.811s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6954bda into hashicorp:main Mar 28, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 28, 2022
@justinretzolk justinretzolk mentioned this pull request Mar 31, 2022
Closed
@DrFaust92 DrFaust92 deleted the dlm branch April 2, 2022 19:04
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.9.0
2 participants
@DrFaust92 @ewbankkit