Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_fsx_lustre_file_system support Persistent 2, add new resource aws_fsx_data_repository_association #22291

Merged
merged 10 commits into from
Jan 20, 2022
Merged

aws_fsx_lustre_file_system support Persistent 2, add new resource aws_fsx_data_repository_association #22291

merged 10 commits into from
Jan 20, 2022

Conversation

vicyap
Copy link
Contributor

@vicyap vicyap commented Dec 21, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

About

  • Updates aws_fsx_lustre_file_system to support PERSISTENT_2 as a deployment type.
  • Adds a new resource, aws_fsx_data_repository_association to link S3 buckets to FSx for Lustre Filesystems using Persistent 2.

Docs: https://docs.aws.amazon.com/fsx/latest/LustreGuide/overview-dra-data-repo.html

Closes #22279

I probably missed a few things. Please let me know anything I should address!

Output from acceptance testing:

$ make testacc ACCTEST_PARALLELISM=10 PKG=fsx TESTS='TestAccFSxDataRepositoryAssociation_*|TestAccFSxLustreFileSystem_deploymentTypePersistent2|TestAccFSxLustreFileSystem_fileSystemTypeVersion'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run='TestAccFSxDataRepositoryAssociation_*|TestAccFSxLustreFileSystem_deploymentTypePersistent2|TestAccFSxLustreFileSystem_fileSystemTypeVersion' -timeout 180m
=== RUN   TestAccFSxDataRepositoryAssociation_basic
=== PAUSE TestAccFSxDataRepositoryAssociation_basic
=== RUN   TestAccFSxDataRepositoryAssociation_disappears
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears
=== RUN   TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== RUN   TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== PAUSE TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== RUN   TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== PAUSE TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== CONT  TestAccFSxDataRepositoryAssociation_basic
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== CONT  TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== CONT  TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2 (531.51s)
=== CONT  TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
--- PASS: TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem (673.84s)
=== CONT  TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
--- PASS: TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated (814.48s)
=== CONT  TestAccFSxDataRepositoryAssociation_disappears
--- PASS: TestAccFSxDataRepositoryAssociation_basic (898.54s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSize
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy (942.60s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy (1046.42s)
--- PASS: TestAccFSxLustreFileSystem_fileSystemTypeVersion (1127.75s)
--- PASS: TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem (606.02s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate (1160.87s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3FullPolicy (1346.61s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate (1491.98s)
--- PASS: TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated (838.60s)
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSize (651.49s)
--- PASS: TestAccFSxDataRepositoryAssociation_disappears (741.27s)
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated (772.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        1718.381s

Support AWS FSx for Lustre Persistent 2
615a059 
* Updates `aws_fsx_lustre_file_system` to accept `PERSISTENT_2` as a
  deployment type.
* Adds `aws_fsx_data_repository_association`.
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Dec 21, 2021
github-actions[bot]
github-actions bot reviewed Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @vicyap 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@vicyap vicyap mentioned this pull request Dec 21, 2021
Closed
@vicyap vicyap changed the title [WIP] aws_fsx_lustre_file_system support Persistent 2, add new resource aws_fsx_data_repository_association aws_fsx_lustre_file_system support Persistent 2, add new resource aws_fsx_data_repository_association Dec 29, 2021
@vicyap vicyap marked this pull request as ready for review December 29, 2021 18:08
jrykr
jrykr reviewed Jan 1, 2022
View reviewed changes
Copy link

@jrykr jrykr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks.

internal/provider/provider.go Show resolved Hide resolved
website/docs/r/fsx_data_repository_association.html.markdown Outdated Show resolved Hide resolved
@vicyap
Copy link
Contributor Author

vicyap commented Jan 7, 2022

@jrykr I updated the PR with a typo fix.

What other changes do I need to make?

@jrykr
Copy link

jrykr commented Jan 8, 2022

@vicyap, lgtm, but I'm not a maintainer.

@DrFaust92, would you be able to help get this PR triaged?

@vicyap
Copy link
Contributor Author

vicyap commented Jan 13, 2022

Hello @DrFaust92, are there any updates on this PR? I understand this project is full of PRs to be reviewed. Any estimate on when this will get reviewed and merged would be helpful.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2022
@DrFaust92 DrFaust92 mentioned this pull request Jan 19, 2022
Closed
DrFaust92
DrFaust92 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant verify tests at the moment but looks great!

@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 19, 2022
DrFaust92
DrFaust92 reviewed Jan 19, 2022
View reviewed changes
.changelog/22291.txt Outdated Show resolved Hide resolved
@breathingdust
Copy link
Member

breathingdust commented Jan 20, 2022 •
edited
Loading

Hey @DrFaust92! I can validate tests tonight, thanks for the review 🚀

@breathingdust
Copy link
Member

Verified Tests in Commercial (us-west-2)

make testacc ACCTEST_PARALLELISM=10 PKG=fsx TESTS='TestAccFSxDataRepositoryAssociation_*|TestAccFSxLustreFileSystem_deploymentTypePersistent2|TestAccFSxLustreFileSystem_fileSystemTypeVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run='TestAccFSxDataRepositoryAssociation_*|TestAccFSxLustreFileSystem_deploymentTypePersistent2|TestAccFSxLustreFileSystem_fileSystemTypeVersion' -timeout 180m
=== RUN   TestAccFSxDataRepositoryAssociation_basic
=== PAUSE TestAccFSxDataRepositoryAssociation_basic
=== RUN   TestAccFSxDataRepositoryAssociation_disappears
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears
=== RUN   TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== RUN   TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== PAUSE TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== RUN   TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== PAUSE TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== CONT  TestAccFSxDataRepositoryAssociation_basic
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== CONT  TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== CONT  TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== CONT  TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2 (585.71s)
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
--- PASS: TestAccFSxDataRepositoryAssociation_basic (715.42s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
--- PASS: TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated (730.29s)
=== CONT  TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
--- PASS: TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated (792.95s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSize
--- PASS: TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem (906.53s)
=== CONT  TestAccFSxDataRepositoryAssociation_disappears
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy (941.10s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3FullPolicy (1207.10s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy (1217.60s)
--- PASS: TestAccFSxLustreFileSystem_fileSystemTypeVersion (1246.37s)
--- PASS: TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem (671.86s)
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSize (657.77s)
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated (755.33s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate (1512.04s)
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate (961.22s)
--- PASS: TestAccFSxDataRepositoryAssociation_disappears (953.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1863.510s

Hi @vicyap 👋. The tests are failing in GovCloud as Persistent2 is not available in that partition. Typically what we do is modify the tests so they they skip rather than fail when run there. We will follow up with that change ourselves as its unlikely you have a GovCloud account to test in!

Looks like this is almost GTG, just need some formatting fixes to get the Acceptance Test Linting check to go green and the CHANGELOG entry @DrFaust92 mentioned and we can merge!

ewbankkit
ewbankkit approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccFSxDataRepositoryAssociation_\|TestAccFSxLustreFileSystem_' PKG=fsx ACCTEST_PARALLELISM=10
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run=TestAccFSxDataRepositoryAssociation_\|TestAccFSxLustreFileSystem_ -timeout 180m
=== RUN   TestAccFSxDataRepositoryAssociation_basic
=== PAUSE TestAccFSxDataRepositoryAssociation_basic
=== RUN   TestAccFSxDataRepositoryAssociation_disappears
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears
=== RUN   TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== PAUSE TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
=== RUN   TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSize
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== PAUSE TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
=== RUN   TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== PAUSE TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== PAUSE TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
=== RUN   TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== PAUSE TestAccFSxDataRepositoryAssociation_s3FullPolicy
=== RUN   TestAccFSxLustreFileSystem_basic
=== PAUSE TestAccFSxLustreFileSystem_basic
=== RUN   TestAccFSxLustreFileSystem_disappears
=== PAUSE TestAccFSxLustreFileSystem_disappears
=== RUN   TestAccFSxLustreFileSystem_dataCompression
=== PAUSE TestAccFSxLustreFileSystem_dataCompression
=== RUN   TestAccFSxLustreFileSystem_exportPath
=== PAUSE TestAccFSxLustreFileSystem_exportPath
=== RUN   TestAccFSxLustreFileSystem_importPath
=== PAUSE TestAccFSxLustreFileSystem_importPath
=== RUN   TestAccFSxLustreFileSystem_importedFileChunkSize
=== PAUSE TestAccFSxLustreFileSystem_importedFileChunkSize
=== RUN   TestAccFSxLustreFileSystem_securityGroupIDs
=== PAUSE TestAccFSxLustreFileSystem_securityGroupIDs
=== RUN   TestAccFSxLustreFileSystem_storageCapacity
=== PAUSE TestAccFSxLustreFileSystem_storageCapacity
=== RUN   TestAccFSxLustreFileSystem_storageCapacityUpdate
=== PAUSE TestAccFSxLustreFileSystem_storageCapacityUpdate
=== RUN   TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== PAUSE TestAccFSxLustreFileSystem_fileSystemTypeVersion
=== RUN   TestAccFSxLustreFileSystem_tags
=== PAUSE TestAccFSxLustreFileSystem_tags
=== RUN   TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxLustreFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== RUN   TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypePersistent2
=== RUN   TestAccFSxLustreFileSystem_fromBackup
=== PAUSE TestAccFSxLustreFileSystem_fromBackup
=== RUN   TestAccFSxLustreFileSystem_kmsKeyID
=== PAUSE TestAccFSxLustreFileSystem_kmsKeyID
=== RUN   TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== PAUSE TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== RUN   TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== PAUSE TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== RUN   TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== PAUSE TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== RUN   TestAccFSxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccFSxLustreFileSystem_copyTagsToBackups
=== RUN   TestAccFSxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccFSxLustreFileSystem_autoImportPolicy
=== CONT  TestAccFSxDataRepositoryAssociation_basic
=== CONT  TestAccFSxLustreFileSystem_importedFileChunkSize
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent1
=== CONT  TestAccFSxLustreFileSystem_autoImportPolicy
=== CONT  TestAccFSxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone
=== CONT  TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead
=== CONT  TestAccFSxLustreFileSystem_deploymentTypeScratch2
=== CONT  TestAccFSxLustreFileSystem_kmsKeyID
=== CONT  TestAccFSxLustreFileSystem_fromBackup
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent1 (668.57s)
=== CONT  TestAccFSxLustreFileSystem_deploymentTypePersistent2
--- PASS: TestAccFSxLustreFileSystem_copyTagsToBackups (690.38s)
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
--- PASS: TestAccFSxLustreFileSystem_storageTypeHddDriveCacheRead (710.17s)
=== CONT  TestAccFSxLustreFileSystem_importPath
=== CONT  TestAccFSxDataRepositoryAssociation_s3FullPolicy
--- PASS: TestAccFSxDataRepositoryAssociation_basic (810.24s)
--- PASS: TestAccFSxLustreFileSystem_deploymentTypeScratch2 (814.54s)
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
--- PASS: TestAccFSxLustreFileSystem_storageTypeHddDriveCacheNone (899.64s)
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
--- PASS: TestAccFSxLustreFileSystem_deploymentTypePersistent2 (577.11s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSize
--- PASS: TestAccFSxLustreFileSystem_kmsKeyID (1324.42s)
=== CONT  TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
--- PASS: TestAccFSxLustreFileSystem_fromBackup (1391.03s)
=== CONT  TestAccFSxLustreFileSystem_basic
--- PASS: TestAccFSxLustreFileSystem_autoImportPolicy (1427.43s)
=== CONT  TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate (1230.85s)
=== CONT  TestAccFSxLustreFileSystem_exportPath
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSize (693.10s)
=== CONT  TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
--- PASS: TestAccFSxLustreFileSystem_importedFileChunkSize (1939.17s)
=== CONT  TestAccFSxLustreFileSystem_dataCompression
--- PASS: TestAccFSxLustreFileSystem_basic (651.82s)
=== CONT  TestAccFSxLustreFileSystem_tags
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy (1157.67s)
=== CONT  TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxDataRepositoryAssociation_s3FullPolicy (1351.17s)
=== CONT  TestAccFSxLustreFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem (797.36s)
=== CONT  TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate (1552.76s)
=== CONT  TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
--- PASS: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy (1189.80s)
=== CONT  TestAccFSxLustreFileSystem_disappears
--- PASS: TestAccFSxLustreFileSystem_importPath (1876.71s)
=== CONT  TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
--- PASS: TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated (783.17s)
=== CONT  TestAccFSxLustreFileSystem_storageCapacityUpdate
--- PASS: TestAccFSxLustreFileSystem_dailyAutomaticBackupStartTime (685.21s)
=== CONT  TestAccFSxLustreFileSystem_fileSystemTypeVersion
--- PASS: TestAccFSxLustreFileSystem_tags (728.38s)
=== CONT  TestAccFSxLustreFileSystem_storageCapacity
--- PASS: TestAccFSxLustreFileSystem_dataCompression (837.49s)
=== CONT  TestAccFSxLustreFileSystem_securityGroupIDs
--- PASS: TestAccFSxLustreFileSystem_automaticBackupRetentionDays (700.31s)
=== CONT  TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
--- PASS: TestAccFSxLustreFileSystem_weeklyMaintenanceStartTime (698.33s)
=== CONT  TestAccFSxDataRepositoryAssociation_disappears
--- PASS: TestAccFSxLustreFileSystem_disappears (600.88s)
--- PASS: TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated (823.38s)
--- PASS: TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem (756.81s)
--- PASS: TestAccFSxDataRepositoryAssociation_disappears (653.33s)
--- PASS: TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated (855.43s)
--- PASS: TestAccFSxLustreFileSystem_fileSystemTypeVersion (1245.74s)
--- PASS: TestAccFSxLustreFileSystem_storageCapacity (1254.98s)
--- PASS: TestAccFSxLustreFileSystem_exportPath (2119.46s)
--- PASS: TestAccFSxLustreFileSystem_securityGroupIDs (1307.18s)
--- PASS: TestAccFSxLustreFileSystem_storageCapacityUpdate (2615.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	5342.182s
GovCloud
% make testacc TESTARGS='-run=TestAccFSxDataRepositoryAssociation_' PKG=fsx ACCTEST_PARALLELISM=10 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 10 -run=TestAccFSxDataRepositoryAssociation_ -timeout 180m
=== RUN   TestAccFSxDataRepositoryAssociation_basic
    data_repository_association_test.go:23: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_basic (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_disappears
    data_repository_association_test.go:62: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_disappears (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem
    data_repository_association_test.go:90: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_disappears_ParentFileSystem (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated
    data_repository_association_test.go:119: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_fileSystemPathUpdated (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated
    data_repository_association_test.go:161: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_dataRepositoryPathUpdated (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSize
    data_repository_association_test.go:206: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_importedFileChunkSize (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated
    data_repository_association_test.go:240: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_importedFileChunkSizeUpdated (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem
    data_repository_association_test.go:281: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_deleteDataInFilesystem (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy
    data_repository_association_test.go:314: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicy (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate
    data_repository_association_test.go:350: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_s3AutoExportPolicyUpdate (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy
    data_repository_association_test.go:395: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicy (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate
    data_repository_association_test.go:431: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_s3AutoImportPolicyUpdate (0.00s)
=== RUN   TestAccFSxDataRepositoryAssociation_s3FullPolicy
    data_repository_association_test.go:476: PERSISTENT_2 deployment_type is not supported in GovCloud partition
--- SKIP: TestAccFSxDataRepositoryAssociation_s3FullPolicy (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3.674s

@ewbankkit
Copy link
Contributor

@vicyap Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 186ca62 into hashicorp:main Jan 20, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 20, 2022
@vicyap vicyap deleted the f-add-aws_fsx_lustre_file_system-persistent-2 branch January 20, 2022 16:56
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrykr jrykr jrykr left review comments

@DrFaust92 DrFaust92 DrFaust92 approved these changes

@github-actions GitHub Actions GitHub Actions left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

Support PERSISTENT_2 in aws_fsx_lustre_file_system
6 participants
@vicyap @jrykr @breathingdust @ewbankkit @DrFaust92 @justinretzolk