Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PERSISTENT_2 in aws_fsx_lustre_file_system #22279

Closed
jrykr opened this issue Dec 17, 2021 · 3 comments · Fixed by #22291
Closed

Support PERSISTENT_2 in aws_fsx_lustre_file_system #22279

jrykr opened this issue Dec 17, 2021 · 3 comments · Fixed by #22291
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@jrykr
Copy link

jrykr commented Dec 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_fsx_lustre_file_system resource currently supports the following values for deployment_type:

  • SCRATCH_1
  • SCRATCH_2
  • PERSISTENT_1

As of approximately November 2021, AWS introduced the PERSISTENT_2 deployment type. This introduces a number of new features in FSx for Lustre, including the ability to create many data repository associations for a given file system. Unlike earlier PERSISTENT_1 data repositories, these associations can be configured to export data back to the source S3 bucket.1

The current resource has import_path and export_path attributes. These would not be applicable to a PERSISTENT_2 deployment. For PERSISTENT_2 file system, its repository associations would need to be configured after the file system is created.

New or Affected Resource(s)

  • aws_fsx_lustre_file_system
  • aws_fsx_lustre_data_repository_association (new)

Potential Terraform Configuration

resource "aws_fsx_lustre_file_system" "example" {
  storage_capacity = 1200
  subnet_ids       = [aws_subnet.example.id]
  deployment_type  = "PERSISTENT_2"
}

resource "aws_fsx_lustre_data_repository_association" "example" {
  file_system_id       = aws_fsx_lustre_file_system.example.id
  file_system_path     = "/example"
  data_repository_path = "s3://${aws_s3_bucket.example.bucket}"
  
  s3 {
    auto_import_policy = "NEW_CHANGED_DELETED"
    auto_export_policy = "NEW_CHANGED_DELETED"
  }  
}

References

Footnotes

  1. https://awscli.amazonaws.com/v2/documentation/api/latest/reference/fsx/create-data-repository-association.html

@jrykr jrykr added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 17, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/fsx Issues and PRs that pertain to the fsx service. labels Dec 17, 2021
@vicyap
Copy link
Contributor

vicyap commented Dec 21, 2021

Hello, I just made a PR for this here: #22291

I worked on this before I noticed you filed this issue so it’s slightly different.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 20, 2022
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
3 participants