Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/launch_template - add support for http_protocol_ipv6 to metadata_options #20796

Merged
merged 4 commits into from
Sep 10, 2021
Merged

r/launch_template - add support for http_protocol_ipv6 to metadata_options #20796

merged 4 commits into from
Sep 10, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 4, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20768

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_'
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (126.00s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (127.37s)
--- PASS: TestAccAWSLaunchTemplate_basic (155.95s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceType (160.34s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (164.18s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (165.21s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (165.34s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (165.95s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (166.59s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (194.49s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (233.89s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (235.55s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (264.61s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (267.38s)
--- PASS: TestAccAWSLaunchTemplate_disappears (118.06s)
--- PASS: TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn (171.55s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (308.73s)
--- PASS: TestAccAWSLaunchTemplate_Name_Prefix (155.45s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (259.03s)
--- PASS: TestAccAWSLaunchTemplate_Name_Generated (160.40s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (185.56s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (350.24s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (160.42s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (136.84s)
--- PASS: TestAccAWSLaunchTemplate_data (124.98s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (411.90s)
--- PASS: TestAccAWSLaunchTemplate_update (250.00s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (433.72s)
--- PASS: TestAccAWSLaunchTemplate_enclaveOptions (289.93s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (290.76s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (225.70s)
--- PASS: TestAccAWSLaunchTemplate_description (171.06s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (470.69s)
--- PASS: TestAccAWSLaunchTemplate_Tags (233.99s)
--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (380.76s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (273.83s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 4, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 4, 2021
@ewbankkit ewbankkit self-assigned this Sep 10, 2021
ewbankkit
ewbankkit approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_'    
TestAccAWSLaunchTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_ -timeout 180m
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== RUN   TestAccAWSLaunchTemplate_Name_Generated
=== PAUSE TestAccAWSLaunchTemplate_Name_Generated
=== RUN   TestAccAWSLaunchTemplate_Name_Prefix
=== PAUSE TestAccAWSLaunchTemplate_Name_Prefix
=== RUN   TestAccAWSLaunchTemplate_disappears
=== PAUSE TestAccAWSLaunchTemplate_disappears
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== RUN   TestAccAWSLaunchTemplate_EbsOptimized
=== PAUSE TestAccAWSLaunchTemplate_EbsOptimized
=== RUN   TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== PAUSE TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== RUN   TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== RUN   TestAccAWSLaunchTemplate_update
=== PAUSE TestAccAWSLaunchTemplate_update
=== RUN   TestAccAWSLaunchTemplate_Tags
=== PAUSE TestAccAWSLaunchTemplate_Tags
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== RUN   TestAccAWSLaunchTemplate_cpuOptions
=== PAUSE TestAccAWSLaunchTemplate_cpuOptions
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t2
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t2
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t3
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t3
=== RUN   TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== PAUSE TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== RUN   TestAccAWSLaunchTemplate_networkInterface
=== PAUSE TestAccAWSLaunchTemplate_networkInterface
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceType
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceType
=== RUN   TestAccAWSLaunchTemplate_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
=== PAUSE TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
=== RUN   TestAccAWSLaunchTemplate_placement_partitionNum
=== PAUSE TestAccAWSLaunchTemplate_placement_partitionNum
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== RUN   TestAccAWSLaunchTemplate_instanceMarketOptions
=== PAUSE TestAccAWSLaunchTemplate_instanceMarketOptions
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== RUN   TestAccAWSLaunchTemplate_metadataOptions
=== PAUSE TestAccAWSLaunchTemplate_metadataOptions
=== RUN   TestAccAWSLaunchTemplate_enclaveOptions
=== PAUSE TestAccAWSLaunchTemplate_enclaveOptions
=== RUN   TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== RUN   TestAccAWSLaunchTemplate_defaultVersion
=== PAUSE TestAccAWSLaunchTemplate_defaultVersion
=== RUN   TestAccAWSLaunchTemplate_updateDefaultVersion
=== PAUSE TestAccAWSLaunchTemplate_updateDefaultVersion
=== CONT  TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t3
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== CONT  TestAccAWSLaunchTemplate_enclaveOptions
=== CONT  TestAccAWSLaunchTemplate_metadataOptions
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_instanceMarketOptions
=== CONT  TestAccAWSLaunchTemplate_data
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t2
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== CONT  TestAccAWSLaunchTemplate_cpuOptions
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
=== CONT  TestAccAWSLaunchTemplate_Tags
=== CONT  TestAccAWSLaunchTemplate_update
=== CONT  TestAccAWSLaunchTemplate_description
=== CONT  TestAccAWSLaunchTemplate_disappears
=== CONT  TestAccAWSLaunchTemplate_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplate_hibernation
--- PASS: TestAccAWSLaunchTemplate_disappears (49.20s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (59.25s)
=== CONT  TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (68.26s)
=== CONT  TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (68.48s)
=== CONT  TestAccAWSLaunchTemplate_EbsOptimized
--- PASS: TestAccAWSLaunchTemplate_basic (70.25s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (70.67s)
=== CONT  TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (71.02s)
=== CONT  TestAccAWSLaunchTemplate_placement_partitionNum
--- PASS: TestAccAWSLaunchTemplate_data (71.91s)
=== CONT  TestAccAWSLaunchTemplate_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (72.11s)
=== CONT  TestAccAWSLaunchTemplate_updateDefaultVersion
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (72.79s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (73.51s)
=== CONT  TestAccAWSLaunchTemplate_defaultVersion
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (118.14s)
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceAddresses
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (122.98s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface
--- PASS: TestAccAWSLaunchTemplate_description (123.68s)
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceType
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (65.17s)
=== CONT  TestAccAWSLaunchTemplate_Name_Prefix
--- PASS: TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn (77.45s)
=== CONT  TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
--- PASS: TestAccAWSLaunchTemplate_enclaveOptions (168.56s)
=== CONT  TestAccAWSLaunchTemplate_Name_Generated
--- PASS: TestAccAWSLaunchTemplate_hibernation (171.23s)
--- PASS: TestAccAWSLaunchTemplate_Tags (173.10s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (180.88s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (112.95s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceType (64.89s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (119.64s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (44.99s)
--- PASS: TestAccAWSLaunchTemplate_Name_Prefix (56.33s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (127.77s)
--- PASS: TestAccAWSLaunchTemplate_update (206.42s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (136.19s)
--- PASS: TestAccAWSLaunchTemplate_Name_Generated (41.15s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (97.77s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (218.46s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (96.48s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (172.41s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (162.71s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (156.47s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (168.59s)
--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (170.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	246.839s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_ -timeout 180m
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== RUN   TestAccAWSLaunchTemplate_Name_Generated
=== PAUSE TestAccAWSLaunchTemplate_Name_Generated
=== RUN   TestAccAWSLaunchTemplate_Name_Prefix
=== PAUSE TestAccAWSLaunchTemplate_Name_Prefix
=== RUN   TestAccAWSLaunchTemplate_disappears
=== PAUSE TestAccAWSLaunchTemplate_disappears
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== RUN   TestAccAWSLaunchTemplate_EbsOptimized
=== PAUSE TestAccAWSLaunchTemplate_EbsOptimized
=== RUN   TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== PAUSE TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== RUN   TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== RUN   TestAccAWSLaunchTemplate_update
=== PAUSE TestAccAWSLaunchTemplate_update
=== RUN   TestAccAWSLaunchTemplate_Tags
=== PAUSE TestAccAWSLaunchTemplate_Tags
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== RUN   TestAccAWSLaunchTemplate_cpuOptions
=== PAUSE TestAccAWSLaunchTemplate_cpuOptions
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t2
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t2
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t3
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t3
=== RUN   TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== PAUSE TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== RUN   TestAccAWSLaunchTemplate_networkInterface
=== PAUSE TestAccAWSLaunchTemplate_networkInterface
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceType
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceType
=== RUN   TestAccAWSLaunchTemplate_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
=== PAUSE TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
=== RUN   TestAccAWSLaunchTemplate_placement_partitionNum
=== PAUSE TestAccAWSLaunchTemplate_placement_partitionNum
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== RUN   TestAccAWSLaunchTemplate_instanceMarketOptions
=== PAUSE TestAccAWSLaunchTemplate_instanceMarketOptions
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== RUN   TestAccAWSLaunchTemplate_metadataOptions
=== PAUSE TestAccAWSLaunchTemplate_metadataOptions
=== RUN   TestAccAWSLaunchTemplate_enclaveOptions
=== PAUSE TestAccAWSLaunchTemplate_enclaveOptions
=== RUN   TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== RUN   TestAccAWSLaunchTemplate_defaultVersion
=== PAUSE TestAccAWSLaunchTemplate_defaultVersion
=== RUN   TestAccAWSLaunchTemplate_updateDefaultVersion
=== PAUSE TestAccAWSLaunchTemplate_updateDefaultVersion
=== CONT  TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t3
=== CONT  TestAccAWSLaunchTemplate_data
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== CONT  TestAccAWSLaunchTemplate_disappears
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t2
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== CONT  TestAccAWSLaunchTemplate_cpuOptions
=== CONT  TestAccAWSLaunchTemplate_Tags
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
=== CONT  TestAccAWSLaunchTemplate_update
=== CONT  TestAccAWSLaunchTemplate_description
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== CONT  TestAccAWSLaunchTemplate_updateDefaultVersion
=== CONT  TestAccAWSLaunchTemplate_metadataOptions
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_enclaveOptions
=== CONT  TestAccAWSLaunchTemplate_defaultVersion
--- PASS: TestAccAWSLaunchTemplate_disappears (69.52s)
=== CONT  TestAccAWSLaunchTemplate_instanceMarketOptions
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (82.40s)
=== CONT  TestAccAWSLaunchTemplate_Name_Prefix
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (83.08s)
=== CONT  TestAccAWSLaunchTemplate_hibernation
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (85.11s)
=== CONT  TestAccAWSLaunchTemplate_associatePublicIPAddress
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (86.67s)
=== CONT  TestAccAWSLaunchTemplate_placement_partitionNum
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (86.90s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
--- PASS: TestAccAWSLaunchTemplate_basic (87.43s)
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceAddresses
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (88.07s)
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceType
--- PASS: TestAccAWSLaunchTemplate_data (88.43s)
=== CONT  TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (89.65s)
=== CONT  TestAccAWSLaunchTemplate_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (96.77s)
=== CONT  TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (120.73s)
=== CONT  TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (132.01s)
=== CONT  TestAccAWSLaunchTemplate_EbsOptimized
--- PASS: TestAccAWSLaunchTemplate_description (134.78s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface
--- PASS: TestAccAWSLaunchTemplate_Name_Prefix (70.50s)
=== CONT  TestAccAWSLaunchTemplate_Name_Generated
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceType (66.84s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (68.88s)
=== CONT  TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
--- PASS: TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn (75.62s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (168.28s)
--- PASS: TestAccAWSLaunchTemplate_Tags (177.35s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (178.01s)
--- PASS: TestAccAWSLaunchTemplate_enclaveOptions (178.01s)
--- PASS: TestAccAWSLaunchTemplate_update (194.31s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (110.26s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (42.96s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (112.08s)
--- PASS: TestAccAWSLaunchTemplate_Name_Generated (48.81s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (206.03s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (88.44s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (130.22s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (85.80s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (73.30s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (134.85s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (162.22s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (159.61s)
--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (159.86s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (124.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	263.355s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 13c394e into hashicorp:main Sep 10, 2021
@DrFaust92 DrFaust92 deleted the r/launch_template_metadata_ipv6 branch September 10, 2021 16:15
@rifelpet rifelpet mentioned this pull request Sep 10, 2021
Merged
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@mbelang mbelang mentioned this pull request Sep 21, 2021
Closed
@ghdiska
Copy link
Contributor

ghdiska commented Sep 23, 2021 •
edited
Loading

look like data_source_aws_launch_template.go was not updated with 3.59 i receive

Error: error setting metadata_options: Invalid address to set: []string{"metadata_options", "0", "http_protocol_ipv6"}

on ../module/local/node-group.tf line 59, in data "aws_launch_template" "default":
59: data "aws_launch_template" "default" {

@ewbankkit ewbankkit mentioned this pull request Sep 23, 2021
Closed
@shibataka000 shibataka000 mentioned this pull request Sep 26, 2021
Merged
@ewbankkit ewbankkit mentioned this pull request Dec 23, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.59.0
Development

Successfully merging this pull request may close these issues.

aws_launch_template support for the IMDS IPv6 endpoint
4 participants
@DrFaust92 @ewbankkit @ghdiska @breathingdust