Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_launch_template: Error after update from 3.58 -> 3.59 #21007

Closed
ewbankkit opened this issue Sep 23, 2021 · 3 comments · Fixed by #21008
Closed

d/aws_launch_template: Error after update from 3.58 -> 3.59 #21007

ewbankkit opened this issue Sep 23, 2021 · 3 comments · Fixed by #21008
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

AWS Provider version v3.59.0.

Affected Resource(s)

Relates: #20796 (comment):

Error: error setting metadata_options: Invalid address to set: []string{"metadata_options", "0", "http_protocol_ipv6"}

on ../module/local/node-group.tf line 59, in data "aws_launch_template" "default":
59: data "aws_launch_template" "default" {

The flattenLaunchTemplateInstanceMetadataOptions function is called from both the Launch Template resource and the corresponding data source. However the data source's schema has not been updated with the new http_protocol_ipv6 attribute.

@github-actions github-actions bot added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 23, 2021
@ewbankkit ewbankkit added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service. and removed service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 23, 2021
@ewbankkit
Copy link
Contributor Author

In our nightly CI:

Test ended in panic.
------- Stdout: -------
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
------- Stderr: -------
panic: Invalid address to set: []string{"metadata_options", "0", "http_protocol_ipv6"}
goroutine 345 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc002878600, 0x8976b91, 0x10, 0x6ff4da0, 0xc002d0e540, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x371
github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsLaunchTemplateRead(0xc002878600, 0x7a6c460, 0xc003b32600, 0xdc6c850, 0xdc3ca00)
  /opt/teamcity-agent/work/2e10e023da0c7520/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_launch_template.go:534 +0x1885
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc0014a8d20, 0x9ae9b48, 0xc002866440, 0xc002878600, 0x7a6c460, 0xc003b32600, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:335 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc0014a8d20, 0x9ae9b48, 0xc002866440, 0xc001e4d200, 0x7a6c460, 0xc003b32600, 0xc003b32600, 0xc001e4d200, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:558 +0xfd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc0025a0570, 0x9ae9b48, 0xc002866440, 0xc001e4c8e0, 0xc002866440, 0x40dba5, 0x8423a20)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/grpc_provider.go:1105 +0x4d6
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadDataSource(0xc001050a60, 0x9ae9bf0, 0xc002866440, 0xc003eb54a0, 0xc001050a60, 0xc00284ecc0, 0xc002a84ba0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/server/server.go:247 +0xe5
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler(0x8720fe0, 0xc001050a60, 0x9ae9bf0, 0xc00284ecc0, 0xc0028505a0, 0x0, 0x9ae9bf0, 0xc00284ecc0, 0xc002b07b00, 0x23f)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:416 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc002d7e000, 0x9b15c18, 0xc004e18480, 0xc002836100, 0xc00386c750, 0xdc070d0, 0x0, 0x0, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/[email protected]/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc002d7e000, 0x9b15c18, 0xc004e18480, 0xc002836100, 0x0)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/[email protected]/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc0024f0090, 0xc002d7e000, 0x9b15c18, 0xc004e18480, 0xc002836100)
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/[email protected]/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
  /opt/teamcity-agent/work/2e10e023da0c7520/pkg/mod/google.golang.org/[email protected]/server.go:857 +0x1fd

@github-actions github-actions bot added this to the v3.60.0 milestone Sep 23, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant