Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/security_groups - add arns attribute #13944

Merged
merged 15 commits into from
Feb 18, 2021
Merged

d/security_groups - add arns attribute #13944

merged 15 commits into from
Feb 18, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 25, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624

Release note for CHANGELOG:

data_source_security_groups: add `arns` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsSecurityGroups_'
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (65.16s)
--- PASS: TestAccDataSourceAwsSecurityGroups_filter (65.36s)

@DrFaust92 DrFaust92 requested a review from a team June 25, 2020 17:31
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 25, 2020
@DrFaust92 DrFaust92 changed the title [WIP]d/security_groups - add arns attribute d/security_groups - add arns attribute Jun 25, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 25, 2020
@DrFaust92 DrFaust92 changed the title d/security_groups - add arns attribute [wip]d/security_groups - add arns attribute Jun 25, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 25, 2020
@DrFaust92 DrFaust92 changed the title [wip]d/security_groups - add arns attribute d/security_groups - add arns attribute Jun 25, 2020
@DrFaust92
Copy link
Collaborator Author

@bflad / @ewbankkit having some trouble tests getting persistent dependency violation with VPC not able to delete. event without the changes. is it something weird im doing?

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 12, 2020 18:14
Base automatically changed from master to main January 23, 2021 00:58
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2021
@bflad
Copy link
Contributor

bflad commented Feb 16, 2021

Hey @DrFaust92 👋 We would love to pick this up on Thursday as part of some gardening work. If you could rebase this and add a changelog file that would be awesome. Thank you!

@ghost ghost added the service/servicediscovery Issues and PRs that pertain to the servicediscovery service. label Feb 16, 2021
@DrFaust92 DrFaust92 removed the service/servicediscovery Issues and PRs that pertain to the servicediscovery service. label Feb 16, 2021
@ghost ghost added the service/servicediscovery Issues and PRs that pertain to the servicediscovery service. label Feb 16, 2021
@DrFaust92
Copy link
Collaborator Author

Done

$ make testacc TESTARGS='-run=TestAccDataSourceAwsSecurityGroups_'
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (65.16s)
--- PASS: TestAccDataSourceAwsSecurityGroups_filter (65.36s)

@YakDriver YakDriver self-assigned this Feb 18, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 18, 2021
YakDriver
YakDriver approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests in GovCloud:

--- PASS: TestAccDataSourceAwsSecurityGroups_filter (26.63s)
--- PASS: TestAccDataSourceAwsSecurityGroups_tag (26.88s)

In us-west-2:

--- PASS: TestAccDataSourceAwsSecurityGroups_tag (23.12s)
--- PASS: TestAccDataSourceAwsSecurityGroups_filter (23.18s)

@YakDriver YakDriver added this to the v3.29.0 milestone Feb 18, 2021
@YakDriver YakDriver merged commit b4f2c19 into hashicorp:main Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
@DrFaust92 DrFaust92 deleted the d/security_group_arn branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @bflad @YakDriver