Add ARN and/or plan time validations to resources/data_sources

[anGie44]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

This particular Issue serves as a log of PRs addressing this tech-debt Issue Topic

New or Affected Resource(s)

ARN Support

• aws_ec2_client_vpn_endpoint
• aws_glue_connection
• aws_ebs_volume
• aws_api_gateway_rest_api
• aws_wafregional_rate_based_rule
• aws_wafregional_rule_group
• aws_wafregional_rule

Plan time validations

• aws_ec2_client_vpn_endpoint
• aws_waf_xss_match_set
• aws_opsworks_application
• aws_spot_fleet_request
• aws_launch_template
• aws_instance

Relates

• r/ec2_client_vpn_endpoint - add arn attribute + plan time validations #13601, r/glue_connection - add arn attribute #13404, r/iam_saml_provider - refactor to use arn package + disappearing test case #13021, r/waf_xss_match_set: read after create + validations #12777, r/aws_opsworks_application - add import support + validations #12383, r/aws_spot_fleet_request - add support for tagging + validations #12295, Support tagging for Gamelift resources - Alias, Build & Session Queue #11486, d/api_gateway_rest_api - add attributes #10971, r/aws_wafregional_rate_based_rule - add tagging support + expose arn + read after create #10897, r/aws_wafregional_rule_group - add tagging support + expose arn + read after create #10896, r/aws_wafregional_rule - add tagging support + expose arn + read after create #10895,

[bflad]

@anGie44 is there a definition of done for this issue?

[anGie44]

that's a good question @bflad! in short, yes - done would be if all resources/data-sources had computed ARNs and validations where applicable, but I believe this issue tries to address too much 😅 . using a naive grep search

grep -L 'd.Set("arn",' aws/resource*.go | grep -v '_test.go$' | wc -l

we still have over 300 resources needed to satisfy just a portion of this issue.

lmk what your thoughts on this are, but I think we should contain the associated PRs as is (so definition of done will be when those are merged) and then moving forward, we should create enhancement issues on a resource/data-source by resource/data-source basis

[anGie44]

Going to close this for the time being as validation changes are captured well enough in changelog files and we aren't monitoring this tech debt item.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.