Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/transit_gateway_route_table - add arn + refactor disappears #13921

Merged
merged 4 commits into from
Nov 12, 2020
Merged

rd/transit_gateway_route_table - add arn + refactor disappears #13921

merged 4 commits into from
Nov 12, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 24, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624, #13527

Release note for CHANGELOG:

resource_aws_transit_gateway_route_table - add arn attribute
data_source_aws_transit_gateway_route_table - add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TransitGatewayRouteTable_|TestAccAWSEc2TransitGatewayRouteTableDataSource_'
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_basic (259.63s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears (272.73s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears_TransitGateway (194.66s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_Tags (359.31s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_Filter (260.58s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_ID (303.85s)

@DrFaust92 DrFaust92 requested a review from a team June 24, 2020 14:56
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 24, 2020
@DrFaust92 DrFaust92 changed the title r/transit_gateway_route_table - add arn + refactor disappears rd/transit_gateway_route_table - add arn + refactor disappears Jun 25, 2020
@DrFaust92 DrFaust92 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jul 9, 2020
@bflad bflad self-assigned this Nov 12, 2020
@bflad bflad added this to the v3.15.0 milestone Nov 12, 2020
bflad
bflad approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me according to the AWS documentation and lack of API field, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2TransitGatewayRouteTable_basic (330.46s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears (338.14s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears_TransitGateway (284.77s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_Tags (337.49s)

--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_Filter (340.52s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_ID (320.56s)

@bflad bflad merged commit 0849a91 into hashicorp:master Nov 12, 2020
bflad added a commit that referenced this pull request Nov 12, 2020
@bflad
Update CHANGELOG for #13921
cdbeb54
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
@DrFaust92 DrFaust92 deleted the r/tgw_rtb_arn branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @bflad