Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/codebuild: Address TestAccAWSCodeBuildProject failure #13450

Closed
anGie44 opened this issue May 21, 2020 · 3 comments · Fixed by #17465
Closed

service/codebuild: Address TestAccAWSCodeBuildProject failure #13450

anGie44 opened this issue May 21, 2020 · 3 comments · Fixed by #17465
Assignees
@bflad
Labels
service/codebuild Issues and PRs that pertain to the codebuild service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@anGie44
Copy link
Contributor

anGie44 commented May 21, 2020 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing which requires manual intervention and may potentially be skipped.

--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s)
    testing.go:683: Step 1 error: errors during apply:
        
        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub

New or Affected Resource(s)

  • aws_resource_codebuild_project
@anGie44 anGie44 added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 21, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 21, 2020
@anGie44 anGie44 mentioned this issue May 21, 2020
Merged
@bflad bflad added service/codebuild Issues and PRs that pertain to the codebuild service. technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 24, 2020
@bflad bflad added this to the Roadmap milestone Feb 2, 2021
@bflad
Copy link
Contributor

bflad commented Feb 2, 2021

TestAccAWSCodeBuildProject_VpcConfig was fixed awhile ago -- TestAccAWSCodeBuildProject_Source_Auth should be hidden behind an environment variable and skipped since it requires manual AWS Console interaction.

@anGie44 anGie44 changed the title service/codebuild: Address TestAccAWSCodeBuildProject failures service/codebuild: Address TestAccAWSCodeBuildProject failure Feb 3, 2021
@bflad
Copy link
Contributor

bflad commented Feb 4, 2021

Just wanted to potentially use the helpers from #17197 instead of just rolling yet another thing to refactor before submitting this.

@bflad bflad self-assigned this Feb 4, 2021
bflad added a commit that referenced this issue Feb 4, 2021
@bflad
resource/aws_codebuild_project: Deprecate source and secondary_source…
5bbdb68 
…s auth blocks

Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html
Reference: #13450

Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing:

```
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s)
    testing.go:683: Step 1 error: errors during apply:

        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
```

The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the `aws_codebuild_source_credential` resource and removing the problematic test rather than temporarily introducing a skipping mechanism.
@bflad bflad mentioned this issue Feb 4, 2021
Merged
bflad added a commit that referenced this issue Mar 17, 2021
@bflad
resource/aws_codebuild_project: Deprecate source and secondary_source…
f726bee 
…s auth blocks

Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html
Reference: #13450

Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing:

```
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s)
    testing.go:683: Step 1 error: errors during apply:

        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
```

The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the `aws_codebuild_source_credential` resource and removing the problematic test rather than temporarily introducing a skipping mechanism.
bflad added a commit that referenced this issue Mar 17, 2021
@bflad
resource/aws_codebuild_project: Deprecate source and secondary_source…
eb9bf5f 
…s auth blocks (#17465)

resource/aws_codebuild_project: Deprecate source and secondary_sources auth blocks

Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html
Reference: #13450

Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing:

```
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s)
    testing.go:683: Step 1 error: errors during apply:

        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
```

The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the `aws_codebuild_source_credential` resource and removing the problematic test rather than temporarily introducing a skipping mechanism.
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@breathingdust breathingdust removed this from the Roadmap milestone Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
service/codebuild Issues and PRs that pertain to the codebuild service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
3 participants
@bflad @breathingdust @anGie44