-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and enable tfproviderlint V001 check: custom SchemaValidateFunc should be replaced with validation.StringMatch() or validation.StringDoesNotMatch() #11872
Labels
linter
Pertains to changes to or issues with the various linters.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
Comments
bflad
added
the
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
label
Feb 3, 2020
github-actions
bot
added
the
needs-triage
Waiting for first response or review from a maintainer.
label
Feb 3, 2020
bflad
added a commit
that referenced
this issue
Feb 3, 2020
Gaps in `tfproviderlint` checking are covered by the following issues: Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #9954 (fix and enable R004) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad
removed
the
needs-triage
Waiting for first response or review from a maintainer.
label
Feb 3, 2020
bflad
added a commit
that referenced
this issue
Feb 4, 2020
Gaps in `tfproviderlint` checking are covered by the following issues: Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #9954 (fix and enable R004) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad
added a commit
that referenced
this issue
Feb 19, 2020
Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
bflad
added a commit
that referenced
this issue
Mar 10, 2020
Reference: #12074 Gaps in `tfproviderlint`/`awsproviderlint` checking are covered by the following issues: Reference: #11888 (fix and enable AWSAT001) Reference: #9950 (fix and enable AT003) Reference: #11862 (fix and enable AT005) Reference: #9951 (fix and enable R001) Reference: #9952 (fix and enable R002) Reference: #9953 (fix and enable R003) Reference: #11863 (fix and enable R005) Reference: #11864 (fix and enable R006) Reference: #12083 (fix and enable R007, R008) Reference: #9955 (fix and enable S006) Reference: #9956 (fix and enable S018) Reference: #11865 (fix and enable S020) Reference: #11866 (fix and enable S022) Reference: #11867 (fix and enable S023) Reference: #11868 (fix and enable S024) Reference: #11869 (fix and enable S031) Reference: #11870 (fix and enable S032) Reference: #11871 (fix and enable S033) Reference: #11872 (fix and enable V001) Reference: #11844 (fix and enable V002, V004, V005, V007, V008)
This was referenced Apr 25, 2020
breathingdust
added
the
linter
Pertains to changes to or issues with the various linters.
label
Oct 27, 2020
This was referenced Mar 24, 2021
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
linter
Pertains to changes to or issues with the various linters.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
Community Note
Description
The custom validation functions noted by this check can be implemented by standard Terraform Plugin SDK helper/validation functions. Some may require multiple function usage such as
validation.All()
withvalidation.StringLenBetween()
andvalidation.StringMatch()
. See also: https://github.com/bflad/tfproviderlint/blob/master/passes/V001/README.mdDue to the amount of reports and potential review complexity, any fixes should likely be done per-resource.
resource_aws_app_cookie_stickiness_policy.go
resource_aws_appsync_datasource.go
resource_aws_appsync_function.go
resource_aws_appsync_graphql_api.go
resource_aws_cloudwatch_event_permission.go
resource_aws_cloudwatch_log_stream.go
resource_aws_codebuild_project.go
resource_aws_db_instance.go
resource_aws_docdb_cluster.go
resource_aws_elastic_transcoder_pipeline.go
resource_aws_elasticsearch_domain.go
resource_aws_glacier_vault.go
resource_aws_iam_group.go
service/iam: replace custom SchemaValidateFunc with provided ones #12865resource_aws_iam_instance_profile.go
service/iam: replace custom SchemaValidateFunc with provided ones #12865 again: linting: Fixproviderlint
V001 errors for IAM resources #23092resource_aws_iam_policy.go
service/iam: replace custom SchemaValidateFunc with provided ones #12865 again: linting: Fixproviderlint
V001 errors for IAM resources #23092resource_aws_iam_role.go
service/iam: replace custom SchemaValidateFunc with provided ones #12865 again: linting: Fixproviderlint
V001 errors for IAM resources #23092aws_iam_role_policy
linting: Fixproviderlint
V001 errors for IAM resources #23092resource_aws_iam_user.go
service/iam: replace custom SchemaValidateFunc with provided ones #12865resource_aws_neptune_cluster.go
resource_aws_organizations_account.go
resource_aws_rds_cluster.go
resource_aws_redshift_cluster.go
service/redshift: tech debt: replace existing custom validators #13019resource_aws_redshift_parameter_group.go
service/redshift: tech debt: replace existing custom validators #13019resource_aws_redshift_security_group.go
service/redshift: tech debt: replace existing custom validators #13019resource_aws_redshift_subnet_group.go
service/redshift: tech debt: replace existing custom validators #13019aws_ssm_document
service/ssm: tech debt: fix V001 errors #23082resource_aws_vpn_connection.go
service/vpn: tech debt: replace custom validation functions #13022aws_worklink_fleet
service/worklink: tech debt: fix V001 linter errors #23089Definition of Done
GNUmakefile
, add-V001
totfproviderlint
command under lint target and have TravisCI testing passAdditional References
The text was updated successfully, but these errors were encountered: