Merge pull request #25822 from silvaalbert/f-aws-outposts-asset-eleva…

…tion add 'rack_elevation' attribute to aws_outposts_asset data source
hashicorp · Jul 15, 2022 · ef39574 · ef39574
2 parents 8852737 + 0a01b58
commit ef39574
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/.changelog/25822.txt b/.changelog/25822.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+data/aws_outposts_asset: Add `rack_elevation` attribute
+```
diff --git a/internal/service/outposts/outpost_asset_data_source.go b/internal/service/outposts/outpost_asset_data_source.go
@@ -32,6 +32,10 @@ func DataSourceOutpostAsset() *schema.Resource {
 				Type:     schema.TypeString,
 				Computed: true,
 			},
+			"rack_elevation": {
+				Type:     schema.TypeInt,
+				Computed: true,
+			},
 			"rack_id": {
 				Type:     schema.TypeString,
 				Computed: true,
@@ -78,6 +82,7 @@ func DataSourceOutpostAssetRead(d *schema.ResourceData, meta interface{}) error
 	d.Set("asset_id", asset.AssetId)
 	d.Set("asset_type", asset.AssetType)
 	d.Set("host_id", asset.ComputeAttributes.HostId)
+	d.Set("rack_elevation", asset.AssetLocation.RackElevation)
 	d.Set("rack_id", asset.RackId)
 	return nil
 }
diff --git a/internal/service/outposts/outpost_asset_data_source_test.go b/internal/service/outposts/outpost_asset_data_source_test.go
@@ -9,27 +9,28 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/internal/acctest"
 )
 
-func TestAccOutpostsAssetDataSource_id(t *testing.T) {
+func TestAccOutpostsAssetDataSource_basic(t *testing.T) {
 	dataSourceName := "data.aws_outposts_asset.test"
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t); acctest.PreCheckOutpostsOutposts(t) },
 		ErrorCheck:        acctest.ErrorCheck(t, outposts.EndpointsID),
 		ProviderFactories: acctest.ProviderFactories,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccOutpostAssetDataSourceConfig_id(),
+				Config: testAccOutpostAssetDataSourceConfig_basic(),
 				Check: resource.ComposeTestCheckFunc(
 					acctest.MatchResourceAttrRegionalARN(dataSourceName, "arn", "outposts", regexp.MustCompile(`outpost/.+`)),
 					resource.TestMatchResourceAttr(dataSourceName, "asset_id", regexp.MustCompile(`^(\w+)$`)),
 					resource.TestCheckResourceAttrSet(dataSourceName, "asset_type"),
+					resource.TestMatchResourceAttr(dataSourceName, "rack_elevation", regexp.MustCompile(`^[\S \n]+$`)),
 					resource.TestMatchResourceAttr(dataSourceName, "rack_id", regexp.MustCompile(`^[\S \n]+$`)),
 				),
 			},
 		},
 	})
 }
 
-func testAccOutpostAssetDataSourceConfig_id() string {
+func testAccOutpostAssetDataSourceConfig_basic() string {
 	return `
 data "aws_outposts_outposts" "test" {}
 

diff --git a/website/docs/d/outposts_asset.html.markdown b/website/docs/d/outposts_asset.html.markdown
@@ -38,4 +38,5 @@ In addition to all arguments above, the following attributes are exported:
 
 * `asset_type` - The type of the asset.
 * `host_id` - The host ID of the Dedicated Hosts on the asset, if a Dedicated Host is provisioned.
+* `rack_elevation` - The position of an asset in a rack measured in rack units.
 * `rack_id` - The rack ID of the asset.