fix: check !d.IsNewResource() before d.SetId("")

#16796 https://github.com/hashicorp/terraform-provider-aws/pull/19307/checks?check_run_id=2554016542 ``` Calling `d.SetId("")` should ensure `!d.IsNewResource()` is checked first ```
hashicorp · May 11, 2021 · b47ccb6 · b47ccb6
1 parent fd94cb2
commit b47ccb6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/aws/resource_aws_appconfig_application.go b/aws/resource_aws_appconfig_application.go
@@ -81,7 +81,7 @@ func resourceAwsAppconfigApplicationRead(d *schema.ResourceData, meta interface{
 
 	output, err := conn.GetApplication(input)
 
-	if isAWSErr(err, appconfig.ErrCodeResourceNotFoundException, "") {
+	if !d.IsNewResource() && isAWSErr(err, appconfig.ErrCodeResourceNotFoundException, "") {
 		log.Printf("[WARN] Appconfig Application (%s) not found, removing from state", d.Id())
 		d.SetId("")
 		return nil

diff --git a/aws/resource_aws_appconfig_environment.go b/aws/resource_aws_appconfig_environment.go
@@ -135,7 +135,7 @@ func resourceAwsAppconfigEnvironmentRead(d *schema.ResourceData, meta interface{
 
 	output, err := conn.GetEnvironment(input)
 
-	if isAWSErr(err, appconfig.ErrCodeResourceNotFoundException, "") {
+	if !d.IsNewResource() && isAWSErr(err, appconfig.ErrCodeResourceNotFoundException, "") {
 		log.Printf("[WARN] Appconfig Environment (%s) not found, removing from state", d.Id())
 		d.SetId("")
 		return nil