Skip to content

Commit

Permalink
Merge pull request #32464 from hashicorp/b-quicksight-visible-range
Browse files Browse the repository at this point in the history
Correct typos in Quicksight flatteners for `visible_range`,  `rows`, and `visibility`
  • Loading branch information
justinretzolk committed Jul 12, 2023
2 parents 14f2982 + 312f168 commit 54cb05c
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 3 deletions.
35 changes: 35 additions & 0 deletions .changelog/32464.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
```release-note:bug
resource/aws_quicksight_template: Fix exception thrown when specifying `definition.sheets.visuals.bar_chart_visual.chart_configuration.category_axis.scrollbar_options.visible_range`
```

```release-note:bug
resource/aws_quicksight_template: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_options.selected_field_options.visibility`
```

```release-note:bug
resource/aws_quicksight_template: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_wells.pivot_table_aggregated_field_wells.rows`
```

```release-note:bug
resource/aws_quicksight_dashboard: Fix exception thrown when specifying `definition.sheets.visuals.bar_chart_visual.chart_configuration.category_axis.scrollbar_options.visible_range`
```

```release-note:bug
resource/aws_quicksight_dashboard: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_options.selected_field_options.visibility`
```

```release-note:bug
resource/aws_quicksight_dashboard: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_wells.pivot_table_aggregated_field_wells.rows`
```

```release-note:bug
resource/aws_quicksight_analysis: Fix exception thrown when specifying `definition.sheets.visuals.bar_chart_visual.chart_configuration.category_axis.scrollbar_options.visible_range`
```

```release-note:bug
resource/aws_quicksight_analysis: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_options.selected_field_options.visibility`
```

```release-note:bug
resource/aws_quicksight_analysis: Fix exception thrown when specifying `definition.sheets.visuals.pivot_table_visual.chart_configuration.field_wells.pivot_table_aggregated_field_wells.rows`
```
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@ func flattenScrollBarOptions(apiObject *quicksight.ScrollBarOptions) []interface
tfMap["visibility"] = aws.StringValue(apiObject.Visibility)
}
if apiObject.VisibleRange != nil {
tfMap["visibile_range"] = flattenVisibleRangeOptions(apiObject.VisibleRange)
tfMap["visible_range"] = flattenVisibleRangeOptions(apiObject.VisibleRange)
}

return []interface{}{tfMap}
Expand Down
4 changes: 2 additions & 2 deletions internal/service/quicksight/schema/visual_pivot_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ func flattenPivotTableAggregatedFieldWells(apiObject *quicksight.PivotTableAggre
tfMap["columns"] = flattenDimensionFields(apiObject.Columns)
}
if apiObject.Rows != nil {
tfMap["row"] = flattenDimensionFields(apiObject.Rows)
tfMap["rows"] = flattenDimensionFields(apiObject.Rows)
}
if apiObject.Values != nil {
tfMap["values"] = flattenMeasureFields(apiObject.Values)
Expand Down Expand Up @@ -1671,7 +1671,7 @@ func flattenPivotTableFieldOption(apiObject []*quicksight.PivotTableFieldOption)
tfMap["custom_label"] = aws.StringValue(config.CustomLabel)
}
if config.Visibility != nil {
tfMap["visbility"] = aws.StringValue(config.Visibility)
tfMap["visibility"] = aws.StringValue(config.Visibility)
}

tfList = append(tfList, tfMap)
Expand Down

0 comments on commit 54cb05c

Please sign in to comment.