Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-090: Automated trusted workflow pinning (2024-08-19) #1028

Merged
merged 2 commits into from
Aug 20, 2024
Merged

SEC-090: Automated trusted workflow pinning (2024-08-19) #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc7777
Result of tsccr-helper -log-level=info gha update -latest .
hashicorp-tsccr[bot] Aug 19, 2024
9b9ad47
Resolve linter errors and warnings
SBGoods Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
- run: go mod download
- run: go test -coverprofile=coverage.out ./...
- run: go tool cover -html=coverage.out -o coverage.html
- uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
- uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
with:
name: go-${{ matrix.go-version }}-coverage
path: coverage.html
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ linters:
- unconvert
- unparam
- unused
- vet
- govet

run:
# Prevent false positive timeouts in CI
Expand Down
4 changes: 2 additions & 2 deletions internal/privatestate/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ func (d *Data) Bytes(ctx context.Context) ([]byte, diag.Diagnostics) {
if !json.Valid(v) {
diags.AddError(
"Error Encoding Private State",
fmt.Sprintf("An error was encountered when validating private state value."+
"An error was encountered when validating private state value."+
fmt.Sprintf("The value associated with key %q is is not valid JSON.\n\n", k)+
"This is always a problem with Terraform or terraform-plugin-framework. Please report this to the provider developer."),
"This is always a problem with Terraform or terraform-plugin-framework. Please report this to the provider developer.",
)

tflog.Error(ctx, "error encoding private state: invalid JSON value", map[string]interface{}{"key": k, "value": v})
Expand Down