Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Sign archives checksum #99

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented May 13, 2020

This is in preparation for #49 as we can't publish any artifacts to releases.hashicorp.com without the signature.

cc @aeschright - FYI we could also verify the signature when installing the LS in VSCode. I'm just not sure what's the best workflow there and whether to bundle the pubkey (probably more secure, less convenient for potential updates) or pull it down from somewhere on demand (theoretically less secure, but more convenient for updates).

@radeksimko radeksimko added this to the v0.3.0 milestone May 13, 2020
@radeksimko radeksimko added the ci Continuous integration/delivery related label May 13, 2020
@radeksimko radeksimko changed the title build: Sign archive checksum build: Sign archives checksum May 13, 2020
@radeksimko radeksimko requested a review from a team May 13, 2020 21:02
@paultyng
Copy link
Contributor

Considering our historic bundling of the HC public key in TF, its probably safe to bundle it in the VSCode extension. We can discuss further internally though what the best strategy is.

@radeksimko radeksimko removed the request for review from a team May 14, 2020 15:43
@radeksimko radeksimko merged commit 7339e27 into master May 14, 2020
@radeksimko radeksimko deleted the release-archive-signing branch May 14, 2020 15:44
@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants