indexer: refactor & improve/cleanup error handling #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-indexer-refactoring
branch
from
b1d2c50
to
8ef3b35
Compare
- capture and log any errors from Deferred jobs - capture and log any errors from other places which were previously skipped on error (via multierror)
This (hack) is no longer necessary since all indexing logic is now self-contained within one package.
radeksimko
force-pushed
the
f-indexer-refactoring
branch
from
8ef3b35
to
59eea8a
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per individual commits messages, this PR aims to add error handling where it was missing to ensure that errors are collected and logged + we can also fail tests if errors occur.
From end-user perspective this is intended to be no-op.