Use moduleCalls.Declared as source for module.calls
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-module-calls-from-config
branch
from
83d3214
to
b492bb3
Compare
radeksimko
reviewed
Jul 6, 2022
This was referenced Jul 7, 2022
dbanck
force-pushed
the
f-module-calls-from-config
branch
from
3a730f0
to
958cbe8
Compare
This removes any nesting in the tree view for now. Hierarchy can be added later by parsing `moduleCalls.Installed` (might be stale) or a new way of parsing local module sources.
Co-authored-by: Radek Simko <[email protected]>
dbanck
force-pushed
the
f-module-calls-from-config
branch
from
958cbe8
to
e15ed9c
Compare
radeksimko
approved these changes
Jul 8, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
module.callscommand to rely on the decoded module calls metadata, introduced in #882.This allows us to instantly update the module calls view when a file inside the module is changed. In addition, because we're not relying on data from the
.terraformfolder anymore, the view never contains stale data.Since we're only getting information about the current module and loose some information about nested modules, we're removing any nested views from the tree view.
Before
After
Resolves #725