Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump LSP structs to gopls 0.8.4 #947

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 10, 2022

There is no particular motivation behind this bump, other than to keep files up-to-date and avoid surprises when more changes accumulate.

Hopefully next time we have to touch this, the structs are properly importable and generated from the JSON data models, so we no longer have to copy them out of gopls, which generates them from TypeScript. 🙈

@radeksimko radeksimko added the dependencies Auto-pinning label Jun 10, 2022
@radeksimko radeksimko changed the title deps: bump LSP structs deps: bump LSP structs to gopls 0.8.4 Jun 16, 2022
@radeksimko radeksimko marked this pull request as ready for review June 16, 2022 12:13
@radeksimko radeksimko requested a review from a team as a code owner June 16, 2022 12:13
@radeksimko radeksimko merged commit 64422be into main Jun 16, 2022
@radeksimko radeksimko deleted the deps-bump-lsp-protocol branch June 16, 2022 13:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants