Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to ModuleMetadata #849

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Add files to ModuleMetadata #849

merged 2 commits into from
Apr 6, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 5, 2022

This PR adds a Files attribute to ModuleMetadata to complement the changes in hashicorp/terraform-schema#101. With the changes to the earlydecoder we now keep a list of files inside a module.

Depends on hashicorp/terraform-schema#101

Depends on hashicorp/hcl-lang#112

Closes #558

@dbanck dbanck added the enhancement New feature or request label Apr 5, 2022
@dbanck dbanck self-assigned this Apr 5, 2022
@dbanck dbanck marked this pull request as ready for review April 5, 2022 13:30
@dbanck dbanck requested a review from a team April 5, 2022 13:30
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in VSCode & Sublime Text, works well! 👍🏻

Happy to re-review and re-test once the upstream PRs are merged.

@radeksimko radeksimko added this to the v0.27.0 milestone Apr 6, 2022
@dbanck dbanck force-pushed the f-goto-local-module-source branch from b6e1b37 to 6ce3479 Compare April 6, 2022 12:35
@dbanck dbanck requested a review from radeksimko April 6, 2022 12:36
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship-it

@dbanck dbanck merged commit 5b56b6a into main Apr 6, 2022
@dbanck dbanck deleted the f-goto-local-module-source branch April 6, 2022 13:10
@github-actions
Copy link

This functionality has been released in v0.27.0 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go to (local) module implementation from source
2 participants