Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid sending empty diagnostics #756

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

radeksimko
Copy link
Member

Previously we were checking length of a map where the key is a filename, which means we'd more often send [] (empty array) diagnostics when nothing has changed.

This removes the unnecessary diagnostics notifications.

@radeksimko radeksimko added the bug Something isn't working label Jan 7, 2022
@radeksimko radeksimko marked this pull request as ready for review January 7, 2022 11:48
@radeksimko radeksimko requested a review from a team January 7, 2022 11:48
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 9316e07 into main Jan 7, 2022
@radeksimko radeksimko deleted the b-avoid-empty-diags branch January 7, 2022 13:01
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants