Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests and path parsing on Windows #73

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Apr 29, 2020

Closes #71
Closes #72


Tested in a Windows VM:

Screenshot 2020-04-29 at 15 09 22

@radeksimko radeksimko added the bug Something isn't working label Apr 29, 2020
@radeksimko radeksimko requested a review from a team April 29, 2020 14:07
@radeksimko radeksimko mentioned this pull request Apr 29, 2020
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM for local system paths, we'll probably need to talk about UNC paths at some point, I'll open an issue to investigate them, see if I can come up with a repro.

@radeksimko
Copy link
Member Author

Agreed, also the implementation is very similar to gopls’ one, but the main difference is that we detect Windows-style paths based on where the LS is running (build flags), which technically isn’t correct, as the OS of client and server may differ (i.e. Unix-built LS may receive Windows-style paths), but there are other parts of LS which don’t account for this eventuality anyway, so I can address that also in a separate issue/PR.

@radeksimko radeksimko merged commit bdd58fc into master Apr 29, 2020
@radeksimko radeksimko deleted the fix-tests-windows branch April 29, 2020 21:41
@radeksimko radeksimko removed the request for review from a team May 6, 2020 06:57
@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization broken on Windows build: Fix failing tests on Windows
2 participants