ModuleLoader: Run defered operations in the same routine #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we ran Defer as part of a separate goroutine because there were blocking operations scheduled and waited for as part of defer, which could in turn block the originating operation. As all tasks are now async by default and tests always block on *every* operation until it is finished, this presents an opportunity to clean up some tech debt and remove `time.Sleep`.
This is to prevent deadlock in tests, which may still occasionally end up in a situation where two or more of the same operations are scheduled at a time.
|
Unfortunately this won't be as simple as I thought - some tests still seem to end up in a deadlock 😑 Filed #719 and closing this for now. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we ran
Deferas part of a separate goroutine because there were occasionally blocking operations scheduled and waited for as part ofDefer, which could in turn result in a deadlock with the originating operation.As all tasks are now async by default (outside of tests) and tests always block on every operation until it is finished, this presents an opportunity to clean up some tech debt and remove
time.Sleep.The second commit further prevents deadlocks by marking duplicate operations automatically as done.