fix: Avoid crash in telemetry on module removal #707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce this by removing a folder from a workspace, but I also noticed that the VS Code client in particular sends
shutdown
to the server instead ofdidChangeWorkspaceFolder
with the removed folder, so we can't really track module removals yet until that client-side bug is addressed.terraform-ls/internal/state/module.go
Lines 252 to 255 in 055cf02
I also noticed that the notifications for folder change would never work because we weren't passing the module manager down to the handler, so it would always error out 🙈 This was there since the beginning #502