Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic module support for variable completion #551

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Add basic module support for variable completion #551

merged 3 commits into from
Jul 22, 2021

Conversation

Nepomuceno
Copy link
Contributor

@Nepomuceno Nepomuceno commented Jun 14, 2021 •
edited by radeksimko
Loading

2021-07-23 10 25 38

radeksimko
radeksimko reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing this early!

internal/terraform/module/module_manager.go Outdated Show resolved Hide resolved
@Nepomuceno Nepomuceno mentioned this pull request Jun 14, 2021
Merged
@radeksimko radeksimko mentioned this pull request Jul 21, 2021
Closed
@radeksimko

This comment has been minimized.

Sign in to view
@Nepomuceno Nepomuceno marked this pull request as ready for review July 22, 2021 09:34
radeksimko
radeksimko reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged hashicorp/terraform-schema#58 so you should be able to just upgrade terraform-schema to the latest rev on main.

Generally this LGTM aside from that one comment about scheduling of the dependent ops. I will get back to you on that. I wouldn't want to get this stalled and/or rebuild the queueing system too significantly, but I want to look into options.

It works well based on my testing with some smaller modules. 👍🏻

.gitignore Outdated Show resolved Hide resolved
internal/state/module.go Outdated Show resolved Hide resolved
internal/terraform/module/module_ops.go Outdated Show resolved Hide resolved
@radeksimko radeksimko mentioned this pull request Jul 22, 2021
Merged
@radeksimko radeksimko merged commit f7e3179 into hashicorp:main Jul 22, 2021
@radeksimko radeksimko mentioned this pull request Jul 22, 2021
Merged
@radeksimko radeksimko added this to the v0.20 milestone Jul 29, 2021
This was referenced Aug 2, 2021
Closed
Closed
Closed
@Nepomuceno Nepomuceno deleted the add-var-module branch August 10, 2021 07:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request textDocument/completion textDocument/hover textDocument/semanticTokens Semantic syntax highlighting
Projects
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@Nepomuceno @radeksimko