Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sourcegraph/go-lsp with gopls' internal/lsp/protocol #311

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Replace sourcegraph/go-lsp with gopls' internal/lsp/protocol #311

merged 3 commits into from
Nov 20, 2020

Commits on Nov 20, 2020

  1. Generate structs from golang/tools internal/lsp/protocol 

    It would be best to import this like a normal package, but
gopls team doesn't feel confident about the stability of their
generator and so this remains under internal for now.

That said this is still currently the most accurate and up to date
structs we can get for Go today with little effort.
    @radeksimko
    radeksimko committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    8765e0d View commit details
    Browse the repository at this point in the history

  2. Replace sourcegraph/go-lsp with internal/protocol

    @radeksimko
    radeksimko committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    ff026ef View commit details
    Browse the repository at this point in the history

  3. Reflect differences between the two libraries

    @radeksimko
    radeksimko committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d93a6fa View commit details
    Browse the repository at this point in the history