Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic by initing universal schema early #307

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 18, 2020

This fixes a race condition which is difficult to reproduce, but hashicorp/terraform-schema#7 has the relevant panic trace.

This practically delivers on the promise mentioned here

err = rm.findAndSetCoreSchema()
if err != nil {
rm.logger.Printf("%s: %s - falling back to universal schema",
rm.Path(), err)
}

In other words I thought this was already done but I must have missed it in #281

@radeksimko radeksimko added the bug Something isn't working label Nov 18, 2020
@radeksimko radeksimko requested a review from a team November 18, 2020 11:19
@radeksimko radeksimko added this to the v0.10.0 milestone Nov 18, 2020
@radeksimko radeksimko merged commit 24b91f7 into master Nov 18, 2020
@radeksimko radeksimko deleted the b-early-universal-schema branch November 18, 2020 16:00
@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants