fix: prevent crash when listing symbols in invalid config #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously ignored all diagnostics, which includes both minor and major, the latter of which prevent the HCL parser from parsing anything and therefore resulting in
nil
being returned fromParseBlockFromTokens
which was then unexpected outcome forBlocks()
.Example of such invalid config
The crash didn't occur during completion because it uses some other position-based methods which would already stop before stepping further into the parser internals and in particular into
ParseBlockFromTokens
. Symbol listing however is not position based and so listing symbols on an invalid config leads to a crash.