Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Terraform version to functions merger #1672

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Mar 28, 2024


Prior to this PR, we would always merge any provider-defined functions included in a schema with the Terraform core functions. Even if the Terraform version doesn't support them yet.

@dbanck dbanck added the bug Something isn't working label Mar 28, 2024
@dbanck dbanck requested a review from a team as a code owner March 28, 2024 16:35
go.mod Show resolved Hide resolved
@ansgarm ansgarm force-pushed the b-add-terraform-version-to-merger branch from a9851e6 to ff7f6f1 Compare April 5, 2024 07:39
@ansgarm
Copy link
Member

ansgarm commented Apr 5, 2024

(rebased onto main)

@ansgarm ansgarm merged commit 0ccb989 into main Apr 5, 2024
21 checks passed
@ansgarm ansgarm deleted the b-add-terraform-version-to-merger branch April 5, 2024 13:31
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider-defined functions are available for Terraform versions < 1.8
3 participants