Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert on wsl.localhost Path #1522

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Alert on wsl.localhost Path #1522

merged 1 commit into from
Dec 20, 2023

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Dec 18, 2023

This adds path detection for network WSL paths to warn the user to open the path in WSL instead.

A user can open a WSL path directly using the network mount path, which results in opening inside the host VS Code instance instead of inside the WSL instance. This is a problem for terraform-ls, which can't resolve the network paths correctly.

@jpogran jpogran self-assigned this Dec 18, 2023
@jpogran jpogran marked this pull request as ready for review December 19, 2023 17:04
@jpogran jpogran requested a review from a team as a code owner December 19, 2023 17:04
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jpogran jpogran merged commit a5ff862 into main Dec 20, 2023
22 checks passed
@jpogran jpogran deleted the test_wsl_localhost_path branch December 20, 2023 15:28
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants