Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL: Instrument PreloadEmbeddedSchema job #1334

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 28, 2023

Follow-up from #1327

Related to #1056

One area identified as consuming significant time when working through some data is the PreloadEmbeddedSchema job. While this isn't necessarily an indication of a bottleneck in itself, this PR adds some further instrumentation to help gain further visibility into that job.

Example dataset:

Screenshot 2023-07-28 at 16 31 40

@radeksimko radeksimko added enhancement New feature or request performance Gotta go fast labels Jul 28, 2023
@radeksimko radeksimko requested a review from a team as a code owner July 28, 2023 14:38
@radeksimko radeksimko mentioned this pull request Jul 28, 2023
3 tasks
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@radeksimko radeksimko merged commit 3a9411f into main Aug 1, 2023
20 checks passed
@radeksimko radeksimko deleted the f-otel-instrument-jobs branch August 1, 2023 09:35
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request performance Gotta go fast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants