-
Notifications
You must be signed in to change notification settings - Fork 130
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
walker: Index uninitialized modules (#997)
* Index uninitialized modules Replacing `filepath.Walk` with `fs.WalkDir`: - makes testing of the walker easier with `testing/fstest`, or any other `fs.FS` compatible libraries. - makes walker aligned with the FS interpretation of the rest of the codebase in that open documents are served from in-memory cache, not from disk - allows for slightly more readable code * go.mod: bump required Go to 1.16 This was actually required since the introduction of io/fs or `os.Readdir()` into filesystem package (introduced only in 1.16), so this is just retrospective. https://pkg.go.dev/io/fs https://pkg.go.dev/os#ReadDir * bump tfschema to 08c17f04e2bc & account for upstream changes Checking MetaState in (ModuleStore).LocalModuleMeta prevents a possible race condition where terraform-schema would otherwise build out module schema just because the module entry is present, but metadata was not parsed yet.
- Loading branch information
1 parent
a7e8a7b
commit c842acf
Showing
20 changed files
with
321 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
internal/langserver/handlers/testdata/uninitialized-single-submodule/application/main.tf
This file was deleted.
Oops, something went wrong.
7 changes: 2 additions & 5 deletions
7
internal/langserver/handlers/testdata/uninitialized-single-submodule/main.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
module "gorilla-app" { | ||
source = "./application" | ||
environment_name = "prod" | ||
app_prefix = "protect-gorillas" | ||
instances = 5 | ||
module "azure-hcp-consul" { | ||
source = "github.com/hashicorp/terraform-azurerm-hcp-consul?ref=v0.2.4" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.