Add checks and plan timestamp for Terraform v1.5 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
May 12, 2023
checks.go
Outdated
Comment on lines
78
to
89
| type CheckDynamicAddress struct { | ||
| // ToDisplay is a formatted and ready to display representation of the | ||
| // full address, including the additional information from the relevant | ||
| // CheckStaticAddress. | ||
| ToDisplay string `json:"to_display"` | ||
|
|
||
| // InstanceKey is the instance key for any instances of a given resource. | ||
| // | ||
| // InstanceKey will be empty if there was no foreach or count argument | ||
| // defined on the containing object. | ||
| InstanceKey string `json:"instance_key,omitempty"` | ||
| } |
There was a problem hiding this comment.
Isn't this one missing the module field per https://github.com/hashicorp/terraform/blob/2a49d4b7844d464404b27b43e23c3ee3cb6eef74/internal/command/jsonchecks/objects.go#L77-L91 ?
There was a problem hiding this comment.
Done! Don't know how I missed it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We are launching v1.5 into beta soon, and these are two features that should be supported in terraform-json.