Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac builds, speed up win builds #72

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Add mac builds, speed up win builds #72

merged 2 commits into from
Sep 25, 2020

Conversation

paultyng
Copy link
Contributor

@paultyng paultyng commented Sep 3, 2020

No description provided.

@paultyng paultyng linked an issue Sep 3, 2020 that may be closed by this pull request
@paultyng
Copy link
Contributor Author

paultyng commented Sep 3, 2020

@kmoe the plan things break on darwin too 😭

@radeksimko
Copy link
Member

the plan things break on darwin too

I fixed that in #89 by skipping these tests on darwin, but we can add some more OS-dependent tests for both Windows and macOS.

@paultyng
Copy link
Contributor Author

Rebased off your PR, #73 is the issue to fix the plan testing for other OS's.

@paultyng
Copy link
Contributor Author

Unsure why these are still failing, I think something weird about the darwin runner but no idea what would cause it and don't have a Mac to investigate atm.

@paultyng paultyng marked this pull request as ready for review September 25, 2020 13:10
@radeksimko
Copy link
Member

It just needed XCode/macOS version bump, because older Terraform versions, like 0.12.29 apparently can't be successfully compiled on older XCode/macOS under some circumstances - due to hashicorp/terraform#24562

This is stderr captured from terraform version after it's compiled as part of the test:

runtime: netpoll: break fd ready for -2
        fatal error: runtime: netpoll: break fd ready for something unexpected

        runtime stack:
        runtime.throw(0x2aa7f25, 0x39)
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/panic.go:1116 +0x72
        runtime.netpoll(0x2540a5275, 0x1)
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/netpoll_kqueue.go:147 +0x33e
        runtime.findrunnable(0xc00005c000, 0x0)
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/proc.go:2434 +0x785
        runtime.schedule()
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/proc.go:2669 +0x2d7
        runtime.park_m(0xc000102600)
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/proc.go:2837 +0x9d
        runtime.mcall(0x80000)
        	/usr/local/Cellar/go/1.15.2/libexec/src/runtime/asm_amd64.s:318 +0x5b

        goroutine 1 [runnable, locked to thread]:
        github.com/ChrisTrenkamp/goxpath/parser.init()
        	/private/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tfinstall-test979244961/vendor/github.com/ChrisTrenkamp/goxpath/parser/ast.go:19 +0xd05

        goroutine 35 [select]:
        go.opencensus.io/stats/view.(*worker).start(0xc00010ef00)
        	/private/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tfinstall-test979244961/vendor/go.opencensus.io/stats/view/worker.go:154 +0x105
        created by go.opencensus.io/stats/view.init.0
        	/private/var/folders/1b/gl7yt7ds26vcyr1pkgld6l040000gn/T/tfinstall-test979244961/vendor/go.opencensus.io/stats/view/worker.go:32 +0x57

@radeksimko radeksimko merged commit afe3776 into master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add darwin test runner
2 participants