Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Race condition on execution when context closes #276

Closed
wants to merge 2 commits into from
Closed

fix: Race condition on execution when context closes #276

wants to merge 2 commits into from

Commits on Feb 2, 2022

  1. fix: Race condition on execution when context closes 

    Accessing ProcessState immediately after context
cancels conflict with the Wait() stdlib func:
https://github.com/golang/go/blob/36b81acfa19d9fedf6a0cd60c394fd7a7703834e/src/os/exec/exec.go#L511
    @kylecarbs
    kylecarbs committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    6994aba View commit details
    Browse the repository at this point in the history

  2. Use CommandContext to kill instead of manually doing it

    @kylecarbs
    kylecarbs committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3a6fff1 View commit details
    Browse the repository at this point in the history