Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): upgrade guide for v0.6 #991

Merged
merged 7 commits into from
Sep 15, 2021
Merged

feat(docs): upgrade guide for v0.6 #991

merged 7 commits into from
Sep 15, 2021

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Sep 10, 2021

@ansgarm ansgarm changed the title Upgrade guide for v0.6 feat(docs): upgrade guide for v0.6 Sep 10, 2021
Copy link
Contributor

@danieldreier danieldreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍 on content. How do we handle UX if a user upgrades without reading this and doesn't update to the newer constructs dependency? I'm wondering if we should error out with an upgrade warning linking to this doc.

docs/upgrade-guide/upgrading-to-0.6.md Show resolved Hide resolved
docs/upgrade-guide/upgrading-to-0.6.md Outdated Show resolved Hide resolved
docs/upgrade-guide/upgrading-to-0.6.md Outdated Show resolved Hide resolved
ansgarm and others added 5 commits September 15, 2021 11:59
this allows cdktf projects using v0.5 to be synthesized with cdktf-cli v0.6
thanks @jsteinich!

Co-authored-by: Jon Steinich <[email protected]>
checks if constructs version is v10
@ansgarm ansgarm dismissed danieldreier’s stale review September 15, 2021 10:26

Added a check that ensures the correct constructs version is installed

docs/upgrade-guide/upgrading-to-0.6.md Outdated Show resolved Hide resolved
packages/cdktf/lib/validateEnvironment.ts Show resolved Hide resolved
@ansgarm ansgarm merged commit 148899e into main Sep 15, 2021
@ansgarm ansgarm deleted the upgrade-guide-v0.6 branch September 15, 2021 13:08
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants