Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): better error for uninitialized provider #896

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Aug 5, 2021

Fixes #822
Fixes #473

@DanielMSchmidt DanielMSchmidt force-pushed the better-handling-of-missing-provider-construct branch 12 times, most recently from 5f2d8f6 to 289c43d Compare August 10, 2021 11:38
@DanielMSchmidt DanielMSchmidt force-pushed the better-handling-of-missing-provider-construct branch 2 times, most recently from 4f1358e to 269de97 Compare August 12, 2021 13:40
@DanielMSchmidt DanielMSchmidt force-pushed the better-handling-of-missing-provider-construct branch from 269de97 to 25cbcc7 Compare August 12, 2021 13:40
@DanielMSchmidt DanielMSchmidt force-pushed the better-handling-of-missing-provider-construct branch 2 times, most recently from 7cf9a9e to fbcc044 Compare August 16, 2021 11:44
we now depend on a feature added in 3.1.0
@DanielMSchmidt DanielMSchmidt force-pushed the better-handling-of-missing-provider-construct branch from fbcc044 to 29b11bb Compare August 16, 2021 12:44
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another conceptual question related to this:
We currently don't advise how users should re-use and pass providers between constructs and/or stacks and this is probably an edge case, but in the Terraform world it is common to define a provider and let modules inherit that one (afaik). If a user wants to use the CDKTF to build such a "provider-config-agnostic" module now, would this change force them to define a provider although they wouldn't want to? (Not that this is a bad thing or a blocker – I just wanted to bring this up)

packages/cdktf/lib/terraform-stack.ts Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt merged commit 655ff3b into main Aug 18, 2021
@DanielMSchmidt DanielMSchmidt deleted the better-handling-of-missing-provider-construct branch August 18, 2021 03:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants