Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Improve telemetry #895

Merged
merged 7 commits into from
Sep 15, 2021
Merged

feat(cli): Improve telemetry #895

merged 7 commits into from
Sep 15, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

This will help us make informed decision and gives us more context on how the CDK is used

Closes #826

@DanielMSchmidt DanielMSchmidt force-pushed the improve-telemetry branch 2 times, most recently from 57ba36d to 2c3faf7 Compare August 5, 2021 18:02
@DanielMSchmidt DanielMSchmidt changed the title feat(telemetry): Improve telemetry feat(cli): Improve telemetry Aug 5, 2021
@DanielMSchmidt DanielMSchmidt force-pushed the improve-telemetry branch 2 times, most recently from 7d7680c to 1c6e1cb Compare August 6, 2021 11:59
packages/cdktf-cli/lib/checkpoint.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/lib/checkpoint.ts Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the improve-telemetry branch 2 times, most recently from e0b0ecc to b5323a1 Compare August 6, 2021 14:29
@danieldreier
Copy link
Contributor

I'm working on an internal RFC and external messaging to explain what data we're collecting and what our privacy controls are, so let's hold off on merging this until that's compelte

@danieldreier
Copy link
Contributor

As prompted by the suggestion @DanielMSchmidt made on the internal RFC, I think we should stop sending command data in to telemetry, because in principal it could contain environment variables or other sensitive information. We already separately track the subcommand being invoked separately from the full command string, and don't use that command telemetry data. @DanielMSchmidt do you have a preference between doing that in this PR vs as a separate issue?

@DanielMSchmidt DanielMSchmidt force-pushed the improve-telemetry branch 9 times, most recently from 3f3995d to a25de67 Compare September 7, 2021 08:55
This will help us make informed decision and gives us more context on how the CDK is used

Closes #826
Copy link
Contributor

@danieldreier danieldreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal RFC has been approved and this is good to go.

@ansgarm ansgarm merged commit a98dac1 into main Sep 15, 2021
@ansgarm ansgarm deleted the improve-telemetry branch September 15, 2021 13:08
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Telemetry
4 participants