chore(docs): add google cloud kubernetes example #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorfmann
suggested changes
Jun 1, 2021
There was a problem hiding this comment.
Looks great! In order to run these as part of the CI pipeline, it'd be good to add a package.json (this will include this example via lerna)
DanielMSchmidt
force-pushed
the
go-example-google-gke
branch
from
e86c65b
to
d35794f
Compare
skorfmann
approved these changes
Jun 9, 2021
DanielMSchmidt
force-pushed
the
go-example-google-gke
branch
from
bcb0f23
to
5b2da57
Compare
adding the example for google cloud might have caused the build to fail as generating the aws provider already requires almost all available memory and simultaneously also generating the google provider might have been to much for the 7 GB of memory available in Github Actions
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.