-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ink v3 #559
Upgrade to ink v3 #559
Conversation
There's a PR to upstream the changes kevva/ink-confirm-input#4
This gets rid of the annoyance of having to take manual snapshots whenever something changes. Plus, it streamlines cross platform tests.
Refactor Integration Tests to Jest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably the least familiar with the UI side of the project, but looks like a fairly straight-forward change.
Yes, overall it's rather straightforward. Primarily changes around |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR upgrades to ink v3. This required a small amount of changes around removed
<Color>
elements. See more details about what changed in v3 here.A few neat things which are made possible by the upgrade:
React Devtools
And in another terminal
Will give you
Terminal Dimensions
With the capability to measure elements and subscribe to terminal dimensions, we are now in a position to handle scrollback issues
Better console output
Doing something like
console.log('foo')
won't be overwritten anymore by the react rendering outputError Boundary
A way nicer way of default handling of errors - see vadimdemedes/ink#303
References
fixes: #166