Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): improve error messages for token resolution #3300

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Nov 28, 2023

Closes #2254
Closes #1890

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos ✌️ Looks good otherwise 💯

packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/tokens/private/resolve.ts Outdated Show resolved Hide resolved
Co-authored-by: Mark DeCrane <[email protected]>
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants