Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run all tests per PR unless skipped #3286

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

mutahhir
Copy link
Member

Description

Enable PR checks to be run for all PRs, since we now have the merge queue. This prevents us from merging things that break the release pipeline.

@ansgarm
Copy link
Member

ansgarm commented Nov 21, 2023

I think that would still not change how the merge queue works 🤔

As far as I understand it, you need to explicitly define what to run in merge queues.
For example we currently have this:

merge_group:
types: [checks_requested]

(and we'd need that for all kinds of checks that we run on PRs)

edit: Or does a merge queue run PR checks by default?

@mutahhir
Copy link
Member Author

I think that would still not change how the merge queue works 🤔

As far as I understand it, you need to explicitly define what to run in merge queues. For example we currently have this:

merge_group:
types: [checks_requested]

(and we'd need that for all kinds of checks that we run on PRs)

edit: Or does a merge queue run PR checks by default?

Yeah, just testing for now. I think since the rules are for branch protections, the merge queue should not be able to merge to that branch, but let's see.

@mutahhir mutahhir merged commit 4bf33d9 into main Nov 21, 2023
212 of 215 checks passed
@mutahhir mutahhir deleted the chore/all-tests-on-pr branch November 21, 2023 13:43
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants