-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run all tests per PR unless skipped #3286
Conversation
I think that would still not change how the merge queue works 🤔 As far as I understand it, you need to explicitly define what to run in merge queues. terraform-cdk/.github/workflows/pr-unit.yml Lines 3 to 4 in 9f70e6f
(and we'd need that for all kinds of checks that we run on PRs) edit: Or does a merge queue run PR checks by default? |
Yeah, just testing for now. I think since the rules are for branch protections, the merge queue should not be able to merge to that branch, but let's see. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Enable PR checks to be run for all PRs, since we now have the merge queue. This prevents us from merging things that break the release pipeline.