fix(provider-generator): fix oci provider by skipping attributes that conflict after being camel cased #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
fix-oci-provider
branch
from
19768a4
to
4b2ee51
Compare
ansgarm
requested review from
mutahhir and
Maed223
and removed request for
a team
DanielMSchmidt
approved these changes
Nov 21, 2023
mutahhir
approved these changes
Nov 21, 2023
… conflict after being camel cased
ansgarm
force-pushed
the
fix-oci-provider
branch
from
e6d03b7
to
30c2b96
Compare
Good call, @DanielMSchmidt! There is a provider integration test at this point, but as soon as the deprecated attributes are removed, nothing tests this case anymore 😅 I'll add a test in a separate branch in order to get this in quicker as it should unblock our pre-release ✌️ |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.